Re: (S) RFR: 8154589: assert(k != NULL) failed: preloaded klass not initialized

2016-05-25 Thread David Holmes
On 25/05/2016 3:05 PM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8154589 webrev: http://cr.openjdk.java.net/~dholmes/8154589/webrev/ We sometimes see tests failing with a VM assertion failure that a klass was not loaded (the actual assertion message is wrong): # assert(

Re: PING: RFR: JDK-8151815: Could not parse core image with JSnap.

2016-05-25 Thread Yasumasa Suenaga
Hi Dmitry, I understand the problem, but I'm concerned of storing pointers to invalid memory region just for coredump. Sorry! The latest webrev [1] holds pointers for PerfMemory in _saved_* fields. These pointers are valid because they are not unmap'ed. I think that it is a bug not to parse P

Re: (S) RFR: 8154589: assert(k != NULL) failed: preloaded klass not initialized

2016-05-25 Thread David Holmes
Can I get a second review please. Thanks, David On 25/05/2016 6:32 PM, David Holmes wrote: On 25/05/2016 3:05 PM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8154589 webrev: http://cr.openjdk.java.net/~dholmes/8154589/webrev/ We sometimes see tests failing with a VM ass