Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-10 Thread David Holmes
On 11/06/2016 2:23 AM, Kirill Zhaldybin wrote: David, Daniel, Mandy, I changed the fix to provide "nicer" message in case if signature is null. Here are a new WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8156226/webrev.06/ Could you please let me know your opinion? Better, but I

Re: RFR: 8072440: serviceability/dcmd/ tests timeout

2016-06-10 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 10 juni 2016, at 09:27, Robbin Ehn wrote: > > Hi all, > > I can not reproduce running the tests mutiple times on mutiple platforms. > And I can not see anything particular in test code. > So I'm removing the @ignore flag for these. > > Bug: https://bugs.openj

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-10 Thread Daniel Fuchs
On 10/06/16 17:23, Kirill Zhaldybin wrote: David, Daniel, Mandy, I changed the fix to provide "nicer" message in case if signature is null. Here are a new WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8156226/webrev.06/ Looks good to me. -- daniel Could you please let me know y

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-10 Thread Kirill Zhaldybin
David, Daniel, Mandy, I changed the fix to provide "nicer" message in case if signature is null. Here are a new WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8156226/webrev.06/ Could you please let me know your opinion? Thank you. Regards, Kirill On 10.06.2016 12:30, David Holme

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-10 Thread David Holmes
On 10/06/2016 6:00 PM, Daniel Fuchs wrote: Hi Kirill, I think you might get a NullPointerException in Arrays.toString(signature) if signature == null, so you should probably guard against that. Yes that addition to line 269 needs more attention as it is not guarded the way the previous varian

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-10 Thread Daniel Fuchs
On 10/06/16 09:00, Daniel Fuchs wrote: Hi Kirill, I think you might get a NullPointerException in Arrays.toString(signature) if signature == null, so you should probably guard against that. Forget that. I should have checked the code before replying ;-( Arrays.toString will return "null" if t

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-10 Thread Daniel Fuchs
Hi Kirill, I think you might get a NullPointerException in Arrays.toString(signature) if signature == null, so you should probably guard against that. best regards, -- daniel On 09/06/16 13:09, Kirill Zhaldybin wrote: Mandy, Thank you for reviewing the fix! I added signature to another erro

RFR: 8072440: serviceability/dcmd/ tests timeout

2016-06-10 Thread Robbin Ehn
Hi all, I can not reproduce running the tests mutiple times on mutiple platforms. And I can not see anything particular in test code. So I'm removing the @ignore flag for these. Bug: https://bugs.openjdk.java.net/browse/JDK-8072440 Webrev: http://cr.openjdk.java.net/~rehn/8072440/webrev/ Thanks