Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-12 Thread Yasumasa Suenaga
Hi David, Thank you for your comment. Is there some reason the option string could not simply become part of the existing configuration string? My first proposal keeps option string at LogOutput and its child class (See webrev.01). Marcus commented that option string should be generated fro

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-12 Thread Yasumasa Suenaga
Marcus commented that option string should be generated from current configuration. Please this email: http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-May/019598.htm On 2016/06/12 22:10, Yasumasa Suenaga wrote: Hi David, Thank you for your comment. Is there some reason the

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-12 Thread David Holmes
On 12/06/2016 11:10 PM, Yasumasa Suenaga wrote: Hi David, Thank you for your comment. Is there some reason the option string could not simply become part of the existing configuration string? My first proposal keeps option string at LogOutput and its child class (See webrev.01). Marcus comme

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-12 Thread Yasumasa Suenaga
Hi David, I think "config_string" is different from "option_string". -Xlog format (from -Xlog:help message): -Xlog[:[what][:[output][:[decorators][:output-options config_string: "what" (ex. gc=trace) option_string: "output-options" (ex. filecount=5) Currently, LogOutput handles tags

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-12 Thread David Holmes
Hi Yasumasa, On 13/06/2016 9:30 AM, Yasumasa Suenaga wrote: Hi David, I think "config_string" is different from "option_string". -Xlog format (from -Xlog:help message): -Xlog[:[what][:[output][:[decorators][:output-options config_string: "what" (ex. gc=trace) option_string: "output-

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-12 Thread David Holmes
On 11/06/2016 6:12 PM, Daniel Fuchs wrote: On 11/06/16 01:41, David Holmes wrote: Better, but I still wonder what Arrays.toString prints for an empty array? It prints "[]" - like Collections.emptyList().toString(): Thanks Daniel. Okay no further comments from me. David - System.o

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-12 Thread Yasumasa Suenaga
Hi David, Thank you for your comment. So options are a distinct property of outputs and so should have been a first class entity in LogOutput all along. I agree to you. But I think we need to discuss about it with logging folks. I uploaded a new webrev. It removes fixed buffer length and ch

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

2016-06-12 Thread David Holmes
Hi Yasumasa, On 13/06/2016 1:45 PM, Yasumasa Suenaga wrote: Hi David, Thank you for your comment. So options are a distinct property of outputs and so should have been a first class entity in LogOutput all along. I agree to you. But I think we need to discuss about it with logging folks. I

Re: RFR: 8072440: serviceability/dcmd/ tests timeout

2016-06-12 Thread Robbin Ehn
Thanks Staffan! /Robbin On 06/10/2016 09:25 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 10 juni 2016, at 09:27, Robbin Ehn wrote: Hi all, I can not reproduce running the tests mutiple times on mutiple platforms. And I can not see anything particular in test code. So I'm remo