Re: RFR: JDK-8159155 Loading the class "sun.tools.jconsole.OutputViewer" shows a modal dialog

2016-06-13 Thread Staffan Larsen
> On 13 juni 2016, at 10:11, Alan Bateman wrote: > > On 13/06/2016 08:57, Staffan Larsen wrote: > >> Please review the small diff below - see the bug for details. This change >> will cause OutputViewer to misbehave if init() is called more than once. But >> since this is an internal class in

Re: RFR: JDK-8159155 Loading the class "sun.tools.jconsole.OutputViewer" shows a modal dialog

2016-06-13 Thread Alan Bateman
On 13/06/2016 08:57, Staffan Larsen wrote: Please review the small diff below - see the bug for details. This change will cause OutputViewer to misbehave if init() is called more than once. But since this is an internal class in jconsole, that restriction is not a problem bug: https://bugs.o

RFR: JDK-8159155 Loading the class "sun.tools.jconsole.OutputViewer" shows a modal dialog

2016-06-13 Thread Staffan Larsen
Please review the small diff below - see the bug for details. This change will cause OutputViewer to misbehave if init() is called more than once. But since this is an internal class in jconsole, that restriction is not a problem bug: https://bugs.openjdk.java.net/browse/JDK-8159155

Re: RFR: 8072440: serviceability/dcmd/ tests timeout

2016-06-13 Thread Robbin Ehn
Thanks Marcus! /Robbin On 06/13/2016 09:36 AM, Marcus Larsson wrote: Looks good to me! Thanks, Marcus On 2016-06-10 09:27, Robbin Ehn wrote: Hi all, I can not reproduce running the tests mutiple times on mutiple platforms. And I can not see anything particular in test code. So I'm removing

Re: RFR: 8072440: serviceability/dcmd/ tests timeout

2016-06-13 Thread Marcus Larsson
Looks good to me! Thanks, Marcus On 2016-06-10 09:27, Robbin Ehn wrote: Hi all, I can not reproduce running the tests mutiple times on mutiple platforms. And I can not see anything particular in test code. So I'm removing the @ignore flag for these. Bug: https://bugs.openjdk.java.net/browse/