[PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

Hi, I'm a developer from IDEA debugger (we have company OCA). We've increased usage of ReferenceTypeImpl.constantPool and now facing JDK-6822627 more often. Please review and sponsor the fix. The problem was that constantPoolBytesRef SoftReference value coud be GCed and there was no check for th

RE: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

Thanks Alan & Mandy for your review comments. I will incorporate your comments and send a fresh review. Amit -Original Message- From: Mandy Chung Sent: Thursday, July 14, 2016 11:32 AM To: David Holmes Cc: Amit Sapre; serviceability-dev; Daniel Fuchs Subject: Re: RFR : JDK-8151099 : java

Re: [PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

The lack of volatile or synchronization, plus the use of multiple mutable fields, suggests that a deeper fix is necessary to be truly correct. For comparison, much of the similar code implementing reflection has been changed to use volatile. But that's a big job, for the serviceability team. On

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

Thank you David for looking into this! Here's the webrev updated in accordance with your and Daniel's suggestions: http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ Please see my answers inline Nit: can we change 'registered_itself" to just "registered" please. Done. Can you explain

Re: RFR : JDK-8158350 Table in ThreadInfo.from(CompositeData) may need updates for new stack trace attributes

On 13/07/2016 12:01, Amit Sapre wrote: Hello, Please review the javadoc update Bug ID : https://bugs.openjdk.java.net/browse/JDK-8158350 webrev : http://cr.openjdk.java.net/~hb/sponsorship/8158350/webrev.01/ Looks good.

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

On 7/14/16 12:46 PM, Ivan Gerasimov wrote: Thank you David for looking into this! Here's the webrev updated in accordance with your and Daniel's suggestions: http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ src/os/windows/vm/os_windows.cpp L3900: bool registered = false;

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

Hey! I've updated the webrev in place at http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ On 15.07.2016 0:31, Daniel D. Daugherty wrote: On 7/14/16 12:46 PM, Ivan Gerasimov wrote: Thank you David for looking into this! Here's the webrev updated in accordance with your and Daniel's sug

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

On 7/14/16 4:57 PM, Ivan Gerasimov wrote: Hey! I've updated the webrev in place at http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ Thumbs up! Dan On 15.07.2016 0:31, Daniel D. Daugherty wrote: On 7/14/16 12:46 PM, Ivan Gerasimov wrote: Thank you David for looking into this! Her

Re: RFR 8160892: VM warning: WaitForMultipleObjects timed out

On 15/07/2016 8:57 AM, Ivan Gerasimov wrote: Hey! I've updated the webrev in place at http://cr.openjdk.java.net/~igerasim/8160892/01/webrev/ Thanks Ivan - looks good. See also: https://bugs.openjdk.java.net/browse/JDK-8160596 https://bugs.openjdk.java.net/browse/JDK-8079441 regarding stran