Thank you, David.
Regards,
Jini.
> -Original Message-
> From: David Holmes
> Sent: Wednesday, July 20, 2016 1:01 PM
> To: Serguei Spitsyn; Jini George; serviceability-dev@openjdk.java.net
> Subject: Re: PING: RFR: JDK-8145627
> (sun.jvm.hotspot.oops.InstanceKlass::getSize() returns the in
Thank you, Serguei. I will be fixing these nits.
Regards,
-Jini
From: Serguei Spitsyn
Sent: Wednesday, July 20, 2016 12:53 PM
To: Jini George; serviceability-dev@openjdk.java.net
Subject: Re: PING: RFR: JDK-8145627
(sun.jvm.hotspot.oops.InstanceKlass::getSize() returns the incorrect si
Christian,
Thank you for the comments.
I agree, this test is over complicated.
Your suggestions for simplifications are good.
Alexander,
Could you, please, update the webrev according to the Christian's comments?
I will re-review it then.
Can you do it tomorrow?
Otherwise, I'm going to vacation
On 20/07/2016 18:11, Daniel D. Daugherty wrote:
We have three reviewers on this changeset. We don't have a review
from a current Serviceability team member, but I think Tim and I
can be considered as sufficient review since we're both former
Serviceability team members. :-)
Alan, please confirm
Hi Alexander,
This test is unnecessarily complicated, it could be simplified a lot.
JvmtiGetAllModulesTest.java
Move getModulesNative() into JvmtiGetAllModulesTest.java and have it return a
Set to be able to use equals later
@27 * @compile JvmtiGetAllModulesTest.java
No need for thi
We have three reviewers on this changeset. We don't have a review
from a current Serviceability team member, but I think Tim and I
can be considered as sufficient review since we're both former
Serviceability team members. :-)
Alan, please confirm that this is good to go.
This change is applied
On 20/07/2016 03:17, David Holmes wrote:
There were some JPRT test failures on OSX and Windows, as this changeset
doesn't affect those platforms I believe they can be ignored.
If this is with "-testset hotspot" then it shouldn't happen, in that
case please drop me an email pointing to the job.
On 7/20/16 02:53, Egor Ushakov wrote:
Yes, all correct, thanks!
Ok, thanks.
Serguei
On 20.07.2016 12:34, serguei.spit...@oracle.com wrote:
Egor,
If I understand correctly, you do not have an openJdk user ID and an
author status.
Please, see the link:
http://openjdk.java.net/census
So
Yes, all correct, thanks!
On 20.07.2016 12:34, serguei.spit...@oracle.com wrote:
Egor,
If I understand correctly, you do not have an openJdk user ID and an
author status.
Please, see the link:
http://openjdk.java.net/census
So that, I'll commit your fix with the comment:
Contributed-by: e
Egor,
If I understand correctly, you do not have an openJdk user ID and an
author status.
Please, see the link:
http://openjdk.java.net/census
So that, I'll commit your fix with the comment:
Contributed-by: egor.usha...@jetbrains.com
and push it to the jdk9/hs.
I hope, somebody will corr
Serguei, thanks for the review!
Please sponsor the fix, I do not know how to proceed.
Thanks!
Egor
On 20.07.2016 10:36, serguei.spit...@oracle.com wrote:
Hi Egor,
Thank you for providing the test!
A couple of nits to the test:
56 if (!Arrays.equals(cpbytes, cpbytes2)) {
On 7/20/16 00:30, David Holmes wrote:
Just to clarify something ...
On 20/07/2016 5:22 PM, serguei.spit...@oracle.com wrote:
Jini,
The fix looks good to me.
Thank you for the update!
Could you fix a couple of nits, please?
test/serviceability/sa/TestInstanceKlassSize.java
156 agent.attach
Hi Egor,
Thank you for providing the test!
A couple of nits to the test:
56 if (!Arrays.equals(cpbytes, cpbytes2)) {
57 failure("Consequent constantPool results vary, first was : " +
cpbytes + ", now: " + cpbytes2);
58 };
Last semicolon is not
Just to clarify something ...
On 20/07/2016 5:22 PM, serguei.spit...@oracle.com wrote:
Jini,
The fix looks good to me.
Thank you for the update!
Could you fix a couple of nits, please?
test/serviceability/sa/TestInstanceKlassSize.java
156 agent.attach( (int) pid);
Do not need to cast t
Jini,
The fix looks good to me.
Thank you for the update!
Could you fix a couple of nits, please?
test/serviceability/sa/TestInstanceKlassSize.java
156 agent.attach( (int) pid);
Do not need to cast to int and the space before pid is not needed.
The lines 114 -120 need standard indentat
15 matches
Mail list logo
