Alexander,
A thumbs up on the push.
I leave it up to you and Christian to tweak and polish the test if you
think it is necessary.
Thank you a lot for working on it!
Thanks,
Serguei
On 7/21/16 14:05, serguei.spit...@oracle.com wrote:
On 7/21/16 11:35, serguei.spit...@oracle.com wrote:
Hi A
Hi Sergey,
Thank you very much for the review. I'm going to wait for any other findings
today and, if everything is fine, will push the fix then.
Best regards,
Alexander
- Original Message -
From: serguei.spit...@oracle.com
To: alexander.kulyakh...@oracle.com, christian.tornqv...@
Hi Alexander,
As Serguei said, the lines 68 and 90 doesn’t check the results so they should
either do that or be removed. If you remove those lines, you can remove the
filtering out of unnamed modules in getModulesJVMTI as well since that will no
longer be necessary.
Minor style thing, m
Hi Christian,
Yes, my intention was to check the equality of the returned data.
I've changed line 68 to:
Asserts.assertEquals(Layer.boot().modules(), getModulesJVMTI());
and removed line 90 since it's not needed.
As to the line 76, that is how Netbeans has formatted the code. I've changed
Hi Alexander,
This looks good, thanks for adding this :)
Thanks,
Christian
From: Alexander Kulyakhtin [mailto:alexander.kulyakh...@oracle.com]
Sent: Friday, July 22, 2016 8:57 AM
To: christian.tornqv...@oracle.com
Cc: serguei.spit...@oracle.com; serviceability-dev@openjdk.java.net
Sub
Hi Christian,
Thank you very much for the review.
Best regards,
Alexander
- Original Message -
From: christian.tornqv...@oracle.com
To: alexander.kulyakh...@oracle.com
Cc: serguei.spit...@oracle.com, serviceability-dev@openjdk.java.net
Sent: Friday, July 22, 2016 4:02:11 PM GMT +
