Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-03 Thread David Holmes
On 4/08/2016 12:07 AM, Frederic Parain wrote: David, Interesting twist about JavaThreads returning to their plain Thread nature before dying. Yes that was quite baffling for a while :) Fix looks good to me. Thanks for the review Fred! David Fred On 08/02/2016 09:13 PM, David Holmes wro

Re: jhsdb jstack cannot work correctly

2016-08-03 Thread Yasumasa Suenaga
Hi Jini, Thank you for your advice! I could get thread dump with this change: - diff -r 5acd2b561936 src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/x86/X86Frame.java --- a/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/x86/X86Frame.java Tue Aug 02

Re: RFR 8160833: ClassesByName2Test.java and RedefineCrossEvent.java failing with jtreg tip

2016-08-03 Thread George Triantafillou
Hi David, Thanks for your review. On 8/2/2016 9:49 PM, David Holmes wrote: Hi George, On 3/08/2016 4:49 AM, George Triantafillou wrote: Please review this small change to fix test failures in two JDI tests: There's only one test changed in the webrev ?? RedefineCrossEvent.java simply runs a

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-03 Thread Frederic Parain
David, Interesting twist about JavaThreads returning to their plain Thread nature before dying. Fix looks good to me. Fred On 08/02/2016 09:13 PM, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8159461/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8159461 The suspen

Re: RFR 8160833: ClassesByName2Test.java and RedefineCrossEvent.java failing with jtreg tip

2016-08-03 Thread George Triantafillou
Thanks Dan! -George On 8/2/2016 3:50 PM, Daniel D. Daugherty wrote: Adding serviceability-dev@... alias since these are JDI tests... Dan On 8/2/16 12:49 PM, George Triantafillou wrote: Please review this small change to fix test failures in two JDI tests: JBS: https://bugs.openjdk.java.net

RE: jhsdb jstack cannot work correctly

2016-08-03 Thread Jini Susan George
Hi Yasumasa, Thanks for noticing this. Regarding the illegal bci, you seem to be right. >From a quick look, this looks like this came in with the introduction of interpreter_frame_mirror_offset. (https://bugs.openjdk.java.net/browse/JDK-8154580). >From frame_x86.hpp, we have: ... 71 inte

jhsdb jstack cannot work correctly

2016-08-03 Thread Yasumasa Suenaga
Hi all, I use "jhsdb jstack" command in JDK 9 EA b129. But it does not seem to work fine. I encountered two problems: 1. AssertionFailure: illegal bci 2. Normal mode cannot work 1. AssertionFailure: illegal bci I saw error stack as below with JDK 9 EA b129 Linux x64: --

RE: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory

2016-08-03 Thread Markus Gronlund
Thanks David! Markus -Original Message- From: David Holmes Sent: den 3 augusti 2016 04:09 To: Markus Gronlund; serviceability-dev@openjdk.java.net Subject: Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory Looks good. Sorry I missed this issue in r