Re: RFR JDK-8152589 : java/lang/management/ThreadMXBean/Locks.java fails intermittently, blocked on wrong object

Hi David, I will incorporate changes suggested by you. Let's wait for few more review comments and then I will send consolidated webrev. Regards Harsha On Wednesday 17 August 2016 09:02 AM, David Holmes wrote: On 16/08/2016 11:33 PM, Harsha Wardhana B wrote: Hi David, Agreed that we could

Re: RFR JDK-8152589 : java/lang/management/ThreadMXBean/Locks.java fails intermittently, blocked on wrong object

On 16/08/2016 11:33 PM, Harsha Wardhana B wrote: Hi David, Agreed that we could fix WaitingThread the way you have said, but in recent past, there aren't any issues reported w.r.t WaitingThread. Nor are there likely to be - that's what makes spurious wakeup bugs so difficult to detect! Thi

Re: Setting JVMTI Capabilities when VM is in "Live Phase"

On 17/08/2016 6:57 AM, Leela Mohan wrote: Your thoughts on this will be helpful. Thanks, Leela [ Removed "serviceability-...@openjdk.net" mailing alias added "hotspot-dev" since i am getting failed mail delivery notification ] Added back - it is openjdk.java.net, not openjdk.net David -

Re: RFR JDK-8152589 : java/lang/management/ThreadMXBean/Locks.java fails intermittently, blocked on wrong object

Hi David, Agreed that we could fix WaitingThread the way you have said, but in recent past, there aren't any issues reported w.r.t WaitingThread. This test has been fixed several times (3-4) for intermittent failures and hence I would not like to meddle with code that is not causing any prob

Re: RFR: JDK-8163581: Heap Parameters in HSDB cannot handle G1CollectedHeap

Hi all, Have you checked changes for this issue? http://cr.openjdk.java.net/~ysuenaga/JDK-8163581/webrev.01/hotspot/ http://cr.openjdk.java.net/~ysuenaga/JDK-8163581/webrev.01/jdk/ For example, ParallelScavengeHeap.java overrides printOn() method. This method shows addresses of each memory

Re: RFR JDK-8151345 : compiler/codecache/jmx/PeakUsageTest.java is failing on jdk9/dev for JPRT -testset hotspot

Thanks for the Review, Staffan. -Harsha On Tuesday 16 August 2016 01:17 PM, Staffan Larsen wrote: Ok. Reviewed. /Staffan On 16 aug. 2016, at 08:15, Harsha Wardhana B wrote: Yes. assertEQorGTE can be used. But using assertEQorLTE is better suited as it increase code readability. So I wou

Re: RFR JDK-8152589 : java/lang/management/ThreadMXBean/Locks.java fails intermittently, blocked on wrong object

Hi Harsha, On 16/08/2016 4:08 PM, Harsha Wardhana B wrote: Hello, Please review and provide comments for fix for issue, https://bugs.openjdk.java.net/browse/JDK-8152589 having webrev located at http://cr.openjdk.java.net/~hb/8152589/webrev.00/ These changes look quite good (though I have t

Re: RFR 8160913: [TEST_BUG] javax/management/security/SecurityTest.java fails due to missing keyStore file

Looks fine to me. Thanks Max On 8/16/2016 14:19, Mallikarjuna Avaluri wrote: Hi, Reminder, please help me with this review. Regards, Mallikarjuna Avaluri On 8/9/2016 11:11 AM, Mallikarjuna Avaluri wrote: Hi all, Could you please review fix for following issue. Bug id: https://bugs.ope

Re: RFR: JDK-8164012: com/sun/jdi/CatchPatternTest.sh fails on jdk9/hs with Required output "Exception occurred: java.lang.IllegalMonitorStateException" not found

Thanks David! The matching logic is not that complicated (but it took me the better part of a day to figure all of this out.) The debugger sets a filter for which exceptions should be reported. Part of that filter includes a class reference. If the exception class IsInstanceOf() the class in th

Re: RFR JDK-8151345 : compiler/codecache/jmx/PeakUsageTest.java is failing on jdk9/dev for JPRT -testset hotspot

Ok. Reviewed. /Staffan > On 16 aug. 2016, at 08:15, Harsha Wardhana B > wrote: > > Yes. assertEQorGTE can be used. But using assertEQorLTE is better suited as > it increase code readability. So I would like to leave that in place. > > > On Saturday 13 August 2016 12:59 AM, Staffan Larsen wr