RFR(S): 8165490: [TESTBUG] sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools

Hello, Please review fix for jdk/test/sun/tools/jps tests. sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools. The problem is that TestJpsJar not add class path to the process builder and fails to find test library classes if these classes were

Re: RFR(S): 8165490: [TESTBUG] sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools

Hello, I withdraw this patch because it's wrong. Thanks! On 06.09.2016 14:43, Dmitry Dmitriev wrote: Hello, Please review fix for jdk/test/sun/tools/jps tests. sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools. The problem is that TestJpsJar n

Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

Hi David, Is this something specific to code added in 9? If so that is motivation as we should not have a new feature with known bugs if we can avoid it. But if this already exists in JDK 8 and is a long standing "bug" ... The change for jvmtiExport.cpp can apply jdk8u: http://hg.openjdk

Re: PING: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

Hi Dmitry, I'll look closely to the fix. Thanks! 1. We typically avoid printing attach error messages on the target VM side. My change will not print error message(s) on the target VM side. Yasumasa On 2016/09/05 22:46, Dmitry Samersoff wrote: Yasumasa, I'll look closely to the fix.

Re: RFR(S): 8165490: [TESTBUG] sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools

FYI: the problem is with new JDK 9 multi-release jar tool which ignores second(and others) '-C .' arguments. Bug: JDK-8165500 "jar not proceed second(and others) -C . arguments" Dmitry On 06.09.2016 15:35, Dmitry Dmitriev wrote: Hello, I w

RFR(XXS): 8165513: Quarantine sun/tools/jps/TestJpsJar.java

Hello, Please review small fix. JDK-8160923 removes this test from problem list, but it still fails due to JDK-8165500 . Thus put sun/tools/jps/TestJpsJar.java back to the problem list with ne

Re: RFR(XXS): 8165513: Quarantine sun/tools/jps/TestJpsJar.java

Dmitry, Looks good for me! -Dmitry On 2016-09-06 19:42, Dmitry Dmitriev wrote: > Hello, > > Please review small fix. JDK-8160923 > removes this test > from problem list, but it still fails due to JDK-8165500 >

Re: RFR(XXS): 8165513: Quarantine sun/tools/jps/TestJpsJar.java

Dmitry, thank you for the review! Dmitry On 06.09.2016 20:32, Dmitry Samersoff wrote: Dmitry, Looks good for me! -Dmitry On 2016-09-06 19:42, Dmitry Dmitriev wrote: Hello, Please review small fix. JDK-8160923 removes this test from problem

Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

Hi Yasumasa, Please, find my comment below. On 9/6/16 06:06, Yasumasa Suenaga wrote: Hi David, Is this something specific to code added in 9? If so that is motivation as we should not have a new feature with known bugs if we can avoid it. But if this already exists in JDK 8 and is a long s

Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

Hi Serguei, I think you would have to justify why this should be a P3 rather than P4 issue. This needs to be answered as well. I've sent it in previous email as below: This problem is that jcmd shows incorrect status when JVMTI agent cannot be attached. I think this problem should be fixe

Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

Hi Yasumasa, On 9/6/16 15:28, Yasumasa Suenaga wrote: Hi Serguei, I think you would have to justify why this should be a P3 rather than P4 issue. This needs to be answered as well. I've sent it in previous email as below: This problem is that jcmd shows incorrect status when JVMTI agent

Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

On 9/6/16 15:46, serguei.spit...@oracle.com wrote: Hi Yasumasa, On 9/6/16 15:28, Yasumasa Suenaga wrote: Hi Serguei, I think you would have to justify why this should be a P3 rather than P4 issue. This needs to be answered as well. I've sent it in previous email as below: This proble

Re: Fwd: Re: [PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

On 9/4/16 20:12, serguei.spit...@oracle.com wrote: Hi Egor, Unfortunately, we are in the RDP1 phase from September 1-st. Only P1-P3 bugs are allowed for fix. We need to find out what is the process if we want to fix this bug in RDP1. I'll check with colleagues what options exist. I've set th

Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

Hi, Then you have to add this justification to the bug report and set the priority to P3. I've updated JBS. BTW, the fix looks good to me. I can sponsor the fix if you have no sponsor yet. Thanks! I've not had a sponsor for this issue. Please sponsor for it. David, can I list you as a r

Re: PING: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

Hi Dmitry, As a sponsor I'm going to push this fix if you are Ok with the fix. Please, let me know if you still have any concerns. Also, confirm if you are Ok to be in the list of reviewers. On 9/5/16 06:46, Dmitry Samersoff wrote: Yasumasa, I'll look closely to the fix. Please, notice: 1.

Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message

On 7/09/2016 1:33 PM, Yasumasa Suenaga wrote: Hi, Then you have to add this justification to the bug report and set the priority to P3. I've updated JBS. BTW, the fix looks good to me. I can sponsor the fix if you have no sponsor yet. Thanks! I've not had a sponsor for this issue. Please