Re: [PING] RFR(s) 8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

Hi Severin, The fix looks good. Thank you for persistence in fixing the issue! The only suggestion is to refactor the lines 800-815 into a method call. Something like deletePoentiallySavedGlobalRefs, similar to deleteGlobalArgumetRefs. Thanks, Serguei On 9/14/16 09:34, Severin Gehwolf wrot

Re: RFR(s) 8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

Severin, The fix looks good for me. I'll sponsor the push, but please wait for Serguei. -Dmitry On 2016-09-09 19:27, Severin Gehwolf wrote: > Hi, > > Could I please get a review of the this 4th version of this fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153711 > webrev: http://cr

Re: [PING] RFR(s) 8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

Anyone? On Fri, 2016-09-09 at 18:27 +0200, Severin Gehwolf wrote: > Hi, > > Could I please get a review of the this 4th version of this fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153711 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8153711/webrev.03/ > > It fixes a mem

RE: RFR: JDK-8068155: [Findbugs]new sun.jvm.hotspot.utilities.ObjectReader() creates a sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which should be performed within a doPrivileged block

David, > That aside, the code uses raw types, which is bad. It should also be able to > retain the this(...) invocation e.g (I haven't compiled this): This works, Thanks. -Sharath Ballal -Original Message- From: David Holmes Sent: Wednesday, September 14, 2016 3:07 PM To: Sharath Bal

Re: RFR(xs): 8166012: [linux] Remove remnants of LinuxThreads from Linux attach framework

Thanks, David! On Wed, Sep 14, 2016 at 11:43 AM, David Holmes wrote: > Hi Thomas, > > On 14/09/2016 7:37 PM, Thomas Stüfe wrote: > >> Please take a look at this small change: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8166012 >> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8166012

Re: RFR(xs): 8166012: [linux] Remove remnants of LinuxThreads from Linux attach framework

On 14/09/2016 10:37, Thomas Stüfe wrote: Please take a look at this small change: Bug: https://bugs.openjdk.java.net/browse/JDK-8166012 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8166012-Remove-remnants-of-LinuxThreads-from-Linux-attach-framework/webrev.00/webrev/

RE: RFR: JDK-8068155: [Findbugs]new sun.jvm.hotspot.utilities.ObjectReader() creates a sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which should be performed within a doPrivileged block

Sundar, > Does SA runs under security manager at all? For eg. can jhsdb tool run under > security manager? I doubt. I am checking on this. -Sharath Ballal From: Sundararajan Athijegannathan Sent: Wednesday, September 14, 2016 1:54 PM To: Sharath Ballal; serviceability-dev@openjdk.java

Re: RFR: 8165017: Additional test coverage of the JDWP CLASSLOADER and MODULE commands

Hi Sergey, Thank you very much for the review. Following your comments I've changed the test summary to "Test the modules-related JDWP commands" and added "@module jdk.jdwp.agent" Please, find the updated webrev at http://cr.openjdk.java.net/~akulyakh/8165017_04/test/serviceability/jdwp/All

Re: RFR: 8165017: Additional test coverage of the JDWP CLASSLOADER and MODULE commands

On 9/14/16 04:01, serguei.spit...@oracle.com wrote: Hi Alexander, This looks good. Thank you for developing this test coverage! Minor comment: http://cr.openjdk.java.net/~akulyakh/8165017_03/test/serviceability/jdwp/AllModulesCommandTest.java.frames.html 33 * @summary Tests AllModules JDW

Re: RFR: 8165017: Additional test coverage of the JDWP CLASSLOADER and MODULE commands

Hi Alexander, This looks good. Thank you for developing this test coverage! Minor comment: http://cr.openjdk.java.net/~akulyakh/8165017_03/test/serviceability/jdwp/AllModulesCommandTest.java.frames.html 33 * @summary Tests AllModules JDWP command Need to also list other JDWP commands t

Re: RFR: 8165017: Additional test coverage of the JDWP CLASSLOADER and MODULE commands

Hi, Could I, please, have some feedback regarding the RFR below? Best regards, Alexander - Original Message - From: alexander.kulyakh...@oracle.com To: serguei.spit...@oracle.com, serviceability-dev@openjdk.java.net Sent: Monday, September 12, 2016 3:06:13 PM GMT +03:00 Iraq Subject: RFR

Re: RFR(xs): 8166012: [linux] Remove remnants of LinuxThreads from Linux attach framework

Hi Thomas, On 14/09/2016 7:37 PM, Thomas Stüfe wrote: Please take a look at this small change: Bug: https://bugs.openjdk.java.net/browse/JDK-8166012 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8166012-Remove-remnants-of-LinuxThreads-from-Linux-attach-framework/webrev.00/webrev/ I notic

RFR(xs): 8166012: [linux] Remove remnants of LinuxThreads from Linux attach framework

Please take a look at this small change: Bug: https://bugs.openjdk.java.net/browse/JDK-8166012 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8166012-Remove-remnants-of-LinuxThreads-from-Linux-attach-framework/webrev.00/webrev/ I noticed this when comparing AIX and Linux attach implementation

Re: RFR: JDK-8068155: [Findbugs]new sun.jvm.hotspot.utilities.ObjectReader() creates a sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which should be performed within a doPrivileged block

Hi Sharath, On 14/09/2016 6:14 PM, Sharath Ballal wrote: Hello, Please review this fix to add creation of classloader code into doPrivileged block Issue: https://bugs.openjdk.java.net/browse/JDK-8068155 Webrev: http://cr.openjdk.java.net/~sballal/8068155/webrev.00/ First I'm also curious ab

Re: RFR: JDK-8068155: [Findbugs]new sun.jvm.hotspot.utilities.ObjectReader() creates a sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which should be performed within a doPrivileged block

Does SA runs under security manager at all? For eg. can jhsdb tool run under security manager? I doubt. Do we want to make it runnable under security manager? If not, does this fix makes sense? -Sundar On 9/14/2016 1:44 PM, Sharath Ballal wrote: > > Hello, > > Please review this fix to add creat

RFR: JDK-8068155: [Findbugs]new sun.jvm.hotspot.utilities.ObjectReader() creates a sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which should be performed within a doPrivileged block

Hello, Please review this fix to add creation of classloader code into doPrivileged block Issue: https://bugs.openjdk.java.net/browse/JDK-8068155 Webrev: http://cr.openjdk.java.net/~sballal/8068155/webrev.00/ -Sharath Ballal