On 9/21/16 9:33 AM, Chris Plummer wrote:
On 9/21/16 7:33 AM, Daniel D. Daugherty wrote:
On 9/20/16 11:07 PM, Chris Plummer wrote:
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8161225
http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/
hotspot/src/sh
On 9/21/16 7:33 AM, Daniel D. Daugherty wrote:
On 9/20/16 11:07 PM, Chris Plummer wrote:
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8161225
http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/
hotspot/src/share/vm/prims/jvmtiEnter.xsl
L490:
Hi Serguei,
Thanks for the review. I'll fix the missing space and run the
java/lang/instrument tests.
thanks,
Chris
On 9/21/16 1:25 AM, serguei.spit...@oracle.com wrote:
Chris,
Forgot to tell about the testing.
You also need to run all the JTREG java/lang/instrument tests.
Thanks,
Serguei
On 9/20/16 11:07 PM, Chris Plummer wrote:
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8161225
http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/
hotspot/src/share/vm/prims/jvmtiEnter.xsl
L490: log_trace(jvmti)("[-] %s %s(%d)", func_na
Hi David,
Thanks again. I included Sergeui's suggestions before pushing the fix.
I also created an enhancement bug to improve the test:
https://bugs.openjdk.java.net/browse/JDK-8166453
Harold
On 9/21/2016 2:37 AM, David Holmes wrote:
Hi Harold,
On 21/09/2016 12:11 AM, harold seigel wrote
Hi Alan,
It is a nice suggestion to use the /make/templates/gpl-cp-header.
But it does not seem easy to reach it from the XSL processing.
So, I left the fix as it is.
Thanks,
Serguei
On 9/20/16 19:43, Alan Bateman wrote:
On 20/09/2016 11:33, serguei.spit...@oracle.com wrote:
Please, review t
Chris,
Forgot to tell about the testing.
You also need to run all the JTREG java/lang/instrument tests.
Thanks,
Serguei
On 9/21/16 01:21, serguei.spit...@oracle.com wrote:
Hi Chris,
It looks good.
One minor comment:
http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/webrev.hotspot/src
Hi Chris,
It looks good.
One minor comment:
http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/webrev.hotspot/src/share/vm/prims/jvmtiEnter.xsl.frames.html
491 JvmtiUtil::error_name(JVMTI_ERROR_WRONG_PHASE),JvmtiEnv::get_phase());
A space is missed after the comma.
Thanks,
Serguei
