RFR (XS): 8160024 jdb returns invalid argument count if first parameter to Arrays.asList is null

2016-11-01 Thread serguei.spit...@oracle.com
Please, review this small fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8160024 JDK webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8160024-JDI-eval.jdk1/ The bug is confidential, so the RFR is sent to the confidential mailing lists. Summary: The JDI incorrectly eval

Re: RFR (XS): 8160024 jdb returns invalid argument count if first parameter to Arrays.asList is null

2016-11-01 Thread serguei.spit...@oracle.com
On 11/1/16 08:58, serguei.spit...@oracle.com wrote: Please, review this small fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8160024 JDK webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8160024-JDI-eval.jdk1/ The bug is confidential, so the RFR is sent to the confidenti

Re: RFR (XS): 8160024 jdb returns invalid argument count if first parameter to Arrays.asList is null

2016-11-01 Thread Daniel D. Daugherty
On 11/1/16 6:58 AM, serguei.spit...@oracle.com wrote: Please, review this small fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8160024 JDK webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8160024-JDI-eval.jdk1/ src/jdk.jdi/share/classes/com/sun/tools/jdi/MethodImpl.java

Re: RFR (XS): 8160024 jdb returns invalid argument count if first parameter to Arrays.asList is null

2016-11-01 Thread serguei.spit...@oracle.com
Dan, Thank you for the review and the suggestions! I'll add the suggested comments. The test is ridiculously simple so that I did not want to make it more complex just for the sake of no shell scripting. :) Thanks! Serguei On 11/1/16 18:03, Daniel D. Daugherty wrote: On 11/1/16 6:58 AM, serg

RE: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall' often throws "Corrupted constant pool" assertion failure

2016-11-01 Thread Jini Susan George
Could I get one more review done for this, please ? Thanks, Jini. > -Original Message- > From: Dmitry Samersoff > Sent: Monday, October 31, 2016 2:58 PM > To: Jini Susan George; serviceability-dev > Subject: Re: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall' often throws > "Corrupted const

Re: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall' often throws "Corrupted constant pool" assertion failure

2016-11-01 Thread Sundararajan Athijegannathan
New files (LingeredAppWithInvokeDynamic.java, TestCpoolForInvokeDynamic.java) should just have current year for copyright (2005, 2015 should be removed). Other than that, +1 -Sundar On 11/2/2016 9:29 AM, Jini Susan George wrote: > Could I get one more review done for this, please ? > Thanks, >

RE: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall' often throws "Corrupted constant pool" assertion failure

2016-11-01 Thread Jini Susan George
Thank you, Sundar! -jini > -Original Message- > From: Sundararajan Athijegannathan > Sent: Wednesday, November 02, 2016 9:35 AM > To: serviceability-dev@openjdk.java.net > Subject: Re: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall' often throws > "Corrupted constant pool" assertion failure