Re: RFR: JDK-8168141: javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java: No notif received!

Gentle remainder Thanks, Ujwal. On 11/4/2016 4:33 PM, Ujwal Vangapally wrote: Please review this small change for the bug below https://bugs.openjdk.java.net/browse/JDK-8168141 Webrev: http://cr.openjdk.java.net/~asapre/sponsorships/Ujwal/JDK-8168141/webrev.01/ Thanks, Ujwal.

Re: RFR: JDK-8168141: javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java: No notif received!

Looks good. -Harsha On Monday 07 November 2016 09:08 PM, Ujwal Vangapally wrote: Gentle remainder Thanks, Ujwal. On 11/4/2016 4:33 PM, Ujwal Vangapally wrote: Please review this small change for the bug below https://bugs.openjdk.java.net/browse/JDK-8168141 Webrev: http://cr.openjdk.ja

RFR: JDK-8169344: Potential open file descriptor in exists() of hotspot/agent/src/os/bsd/ps_core.c

Requesting a review for the small fix for: https://bugs.openjdk.java.net/browse/JDK-8169344 Webrev: http://cr.openjdk.java.net/~jgeorge/8169344/webrev.00/ Thanks, - Jini Susan George

RE: RFR: JDK-7107014: sun.jvm.hotspot.HSDB.FindObjectByTypeCleanupThunk.showConsole.attach infinite loop

Gentle reminder. -Sharath Ballal From: Sharath Ballal Sent: Thursday, November 03, 2016 2:58 PM To: serviceability-dev@openjdk.java.net Subject: RFR: JDK-7107014: sun.jvm.hotspot.HSDB.FindObjectByTypeCleanupThunk.showConsole.attach infinite loop Hello, Pls review the fix for

Re: RFR: JDK-8169344: Potential open file descriptor in exists() of hotspot/agent/src/os/bsd/ps_core.c

Hi, On 8/11/2016 2:08 PM, Jini Susan George wrote: Requesting a review for the small fix for: https://bugs.openjdk.java.net/browse/JDK-8169344 Webrev: http://cr.openjdk.java.net/~jgeorge/8169344/webrev.00/ Looks okay but it can now simplify down to: return access(fname, F_OK) == 0; :) Than

RE: RFR: JDK-8169344: Potential open file descriptor in exists() of hotspot/agent/src/os/bsd/ps_core.c

Thank you, David. Will make this change. -jini > -Original Message- > From: David Holmes > Sent: Tuesday, November 08, 2016 10:05 AM > To: Jini Susan George; serviceability-dev@openjdk.java.net > Subject: Re: RFR: JDK-8169344: Potential open file descriptor in exists() of > hotspot/agent

Re: RFR: JDK-8169344: Potential open file descriptor in exists() of hotspot/agent/src/os/bsd/ps_core.c

Jini, The fix looks OK to me (with David's suggestion). -Dmitry On 2016-11-08 07:39, Jini Susan George wrote: > Thank you, David. Will make this change. > > -jini > >> -Original Message- >> From: David Holmes >> Sent: Tuesday, November 08, 2016 10:05 AM >> To: Jini Susan George; servi

RE: RFR: JDK-8169344: Potential open file descriptor in exists() of hotspot/agent/src/os/bsd/ps_core.c

Thank you, Dmitry. -jini > -Original Message- > From: Dmitry Samersoff > Sent: Tuesday, November 08, 2016 11:22 AM > To: Jini Susan George; David Holmes; serviceability-dev@openjdk.java.net > Subject: Re: RFR: JDK-8169344: Potential open file descriptor in exists() of > hotspot/agent/src/

Re: RFR: JDK-7107018: sun.jvm.hotspot.utilities.soql.JSJavaHeap.forEachClass incorrect test

Jini, The fix looks good to me. -Dmitry On 2016-11-03 07:04, Jini Susan George wrote: > Please review the trivial fix for the bug below (Unfortunately, the bug > is marked confidential): > > > > https://bugs.openjdk.java.net/browse/JDK-7107018 > > > > Webrev: http://cr.openjdk.java.net/

RE: RFR: JDK-7107018: sun.jvm.hotspot.utilities.soql.JSJavaHeap.forEachClass incorrect test

Thank you, Dmitry. -jini > -Original Message- > From: Dmitry Samersoff > Sent: Tuesday, November 08, 2016 11:25 AM > To: Jini Susan George; serviceability-dev@openjdk.java.net > Subject: Re: RFR: JDK-7107018: > sun.jvm.hotspot.utilities.soql.JSJavaHeap.forEachClass incorrect test > > Jin