Re: RFR: JDK-8170861 : Remove DcmdMBeanPermissionsTest.java from ProblemList

2016-12-20 Thread David Holmes
On 21/12/2016 3:08 PM, Ujwal Vangapally wrote: Thanks for the review David, I hope this is good enough for me to push the changes. It is enough for you to run "hg commit" to create the changeset, but you need an OpenJDK Committer to actually push it for you. (Yeah it is confusing that an Auth

Re: RFR: JDK-8170861 : Remove DcmdMBeanPermissionsTest.java from ProblemList

2016-12-20 Thread Ujwal Vangapally
Thanks for the review David, I hope this is good enough for me to push the changes. Ujwal On 12/20/2016 12:22 PM, David Holmes wrote: Looks fine. Thanks, David On 20/12/2016 4:29 PM, Ujwal Vangapally wrote: Please review this small change https://bugs.openjdk.java.net/browse/JDK-8170861

Re: RFR: JDK-8170861 : Remove DcmdMBeanPermissionsTest.java from ProblemList

2016-12-20 Thread Frederic Parain
Looks good to me. Thank you, Fred On 12/20/2016 01:29 AM, Ujwal Vangapally wrote: Please review this small change https://bugs.openjdk.java.net/browse/JDK-8170861 webrev: http://cr.openjdk.java.net/~asapre/sponsorships/Ujwal/JDK-8170861/webrev.00/ Thanks, Ujwal.