Re: RFR (XS): 8172261: [JVMTI] Specification for early VM start event needs to lower expectations in relation class loading

2017-01-18 Thread David Holmes
On 18/01/2017 7:40 PM, Alan Bateman wrote: On 18/01/2017 01:03, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8172261 webrev: http://cr.openjdk.java.net/~dholmes/8172261/webrev/ This looks okay. It might be a bit easier to read if "and attempts" were a new sentence, as in

Re: RFR (XS): 8172261: [JVMTI] Specification for early VM start event needs to lower expectations in relation class loading

2017-01-18 Thread Alan Bateman
On 18/01/2017 01:03, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8172261 webrev: http://cr.openjdk.java.net/~dholmes/8172261/webrev/ This looks okay. It might be a bit easier to read if "and attempts" were a new sentence, as in: "... as it may not be possible to load c

RE: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts "0" instead of assigned port

2017-01-18 Thread Amit Sapre
Hello, Looks like basic check on Jdp packet includes a check for JMX_SERVICE_URL https://java.se.oracle.com/source/xref/jdk9-dev/jdk/test/sun/management/jdp/JdpTestCase.java#184 I feel we don't need any further check on jmx service url. > -Original Message- > From: Roger Riggs > Sent