Re: RFR (S): 8176831: Dead code: function jmm_GetLoadedClasses is not used in jmm_interface

2017-03-16 Thread serguei.spit...@oracle.com
I've reloaded the webrev with pulled latest jdk10 changes. It looks almost the same but has the recent update from Coleen. Thanks, Serguei On 3/16/17 18:20, serguei.spit...@oracle.com wrote: David, Thank you for the review! On 3/16/17 18:15, David Holmes wrote: Looks good! Don't forget to

Re: RFR (S): 8176831: Dead code: function jmm_GetLoadedClasses is not used in jmm_interface

2017-03-16 Thread serguei.spit...@oracle.com
David, Thank you for the review! On 3/16/17 18:15, David Holmes wrote: Looks good! Don't forget to update copyright years. Yes, of course. Thanks, Serguei Thanks, David On 17/03/2017 10:59 AM, serguei.spit...@oracle.com wrote: Please, review the jdk 10 fix for: https://bugs.openjdk.

Re: RFR (S): 8176831: Dead code: function jmm_GetLoadedClasses is not used in jmm_interface

2017-03-16 Thread David Holmes
Looks good! Don't forget to update copyright years. Thanks, David On 17/03/2017 10:59 AM, serguei.spit...@oracle.com wrote: Please, review the jdk 10 fix for: https://bugs.openjdk.java.net/browse/JDK-8176831 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8176831-jmm-dead

RFR (S): 8176831: Dead code: function jmm_GetLoadedClasses is not used in jmm_interface

2017-03-16 Thread serguei.spit...@oracle.com
Please, review the jdk 10 fix for: https://bugs.openjdk.java.net/browse/JDK-8176831 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8176831-jmm-dead.1/ Summary: It was found at the review of the 8155672 that the function jmm_GetLoadedClasses() defined in services/manag

Re: RFR(M): JDK-8061228 Allow JDWP socket connector to accept connections from certain ip addresses only

2017-03-16 Thread Robbin Ehn
Hi Dmitry, thanks for the update. One follow-up issue is that if you start suspended and than connect with an unallowed client the JVM starts and executes the program. Simple program prints "Hello". [rehn@rehn-ws vanilla-hs]$ java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*