Hi Roger,
On Wednesday 11 October 2017 09:21 PM, Roger Riggs wrote:
Hi Harsha,
conf/management.properties: - typo line 307: pa*sss*words
HashedPasswordManager.java:
- line 46: "classes" -> "class"
- line 84-87 "private" and 'static" come before "final" in declarations.
- 158 and everywhe
Hi Daniel,
The contents written into the password file are identical and written at
the same offset. Hence the order of the writes should not matter.
However there is a possibility that file could be read in the midst of
password change and different file contents could be read by different
p
On 10/8/17 10:34 PM, Harsha Wardhana B wrote:
Hi Daniel,
Below is the webrev addressing the review comments.
http://cr.openjdk.java.net/~hb/5016517/webrev.04/
This approach seems reasonable. I only review management.properties
and jmxremote.password.template file.
304 # #
Hi Harsha,
conf/management.properties: - typo line 307: pa*sss*words
HashedPasswordManager.java:
- line 46: "classes" -> "class"
- line 84-87 "private" and 'static" come before "final" in declarations.
- 158 and everywhere: add space after "if" before "("
- line 202: add "the" before pas
Hi Yasumasa,
The changes look fine.
Thanks,
Jini (not a Reviewer).
On 10/10/2017 7:40 AM, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
Thank you for the quick fix!
It looks good.
I'll sponsor your fix after we get at least one more review.
Thanks,
Serguei
On 10/9/17 19:03, Yasumasa Suena
Thanks for the review and suggestions Mandy, Roger.
kindly see my comments inline.
On 10/10/2017 11:25 PM, Roger Riggs wrote:
Hi Ujwal,
In the implementation RuntimeMXBean.java: 72: Include a message
"getProcessId" in the throw new Unsupported...
In the text and @return change "PID" to "pr
Hi Harsha,
Your changes look good. However I have still a nagging doubt:
What happens if two Java process share the same password file,
and it needs hashing? Are there any protection in place
to prevent the two processes from writing to the same
file concurrently?
best regards,
-- daniel
On 0
