Hi Serguei,
This looks good.
-George
On 10/17/2017 1:35 AM, serguei.spit...@oracle.com wrote:
Please, review a fix for the test bug:
https://bugs.openjdk.java.net/browse/JDK-8173936
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8173936-MAA-cflh.1/
Summary:
This test e
Hi George,
Thank you a lot for review!
Serguei
On 10/17/17 05:40, George Triantafillou wrote:
Hi Serguei,
This looks good.
-George
On 10/17/2017 1:35 AM, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
By chance we ran into this bug which I analysed yesterday:
https://bugs.openjdk.java.net/browse/JDK-8189390
We hit the assertion:
# Internal Error (/open/src/hotspot/share/runtime/perfMemory.cpp:216),
pid=17874, tid=17875
# assert(_prologue != __null) failed: called before ini
Hi,
Could I have a review of this change that will adjust an assertion and
remove a lock associated with JFR.
Webrev:
http://cr.openjdk.java.net/~egahlin/8189425_0
Bug:
https://bugs.openjdk.java.net/browse/JDK-8189425
Thanks
Erik
Hi Erik,
On 18/10/2017 12:23 PM, Erik Gahlin wrote:
Hi,
Could I have a review of this change that will adjust an assertion and
Can you explain the adjustment please.
remove a lock associated with JFR.
That bit is fine :)
Thanks,
David
Webrev:
http://cr.openjdk.java.net/~egahlin/818942
Hi,
Could I have a review of a change that adds two macros to be used with
event-based JVM tracing.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8189440
Webrev:
http://cr.openjdk.java.net/~egahlin/8189440_0
Thanks
Erik
Hi David,
> With your changes you no longer null out _prologue so the assertion would
> now not fail and we'd proceed to access the deleted memory region!
On Linux, PerfMemory::delete_memory_region() does not call munmap()
for PerfMemory.
> I'm unclear why you no longer clear all the fields set
Hi Erik,
On 18/10/2017 12:34 PM, Erik Gahlin wrote:
Hi,
Could I have a review of a change that adds two macros to be used with
event-based JVM tracing.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8189440
Webrev:
http://cr.openjdk.java.net/~egahlin/8189440_0
Reviewed - though all somewha
On 18/10/2017 12:37 PM, Yasumasa Suenaga wrote:
Hi David,
With your changes you no longer null out _prologue so the assertion would
now not fail and we'd proceed to access the deleted memory region!
On Linux, PerfMemory::delete_memory_region() does not call munmap()
for PerfMemory.
Perhaps
Hi David,
2017-10-18 12:55 GMT+09:00 David Holmes :
> On 18/10/2017 12:37 PM, Yasumasa Suenaga wrote:
>>
>> Hi David,
>>
>>> With your changes you no longer null out _prologue so the assertion would
>>> now not fail and we'd proceed to access the deleted memory region!
>>
>>
>> On Linux, PerfMemor
On 18/10/2017 2:27 PM, Yasumasa Suenaga wrote:
Hi David,
2017-10-18 12:55 GMT+09:00 David Holmes :
On 18/10/2017 12:37 PM, Yasumasa Suenaga wrote:
Hi David,
With your changes you no longer null out _prologue so the assertion would
now not fail and we'd proceed to access the deleted memory r
Hi David,
> I don't think we need the extra fields, just ensure the existing ones can't
> be accessed (other than by the tools) after destroy is called.
I've added PerfMemory::is_useable() to check whether we can access to
PerfMemory.
I think this webrev prevent to access to PerfMemory after dest
12 matches
Mail list logo