Re: RFR : JDK-8044122 MBean access to the PID

2017-10-27 Thread mandy chung
This interface method provides a default implementation to throw UOE to ease migration but RuntimeMXBean::getPid is not intended to be optional.  In other words, the platform mbean (i.e. JDK implementation of RuntimeMXBean) must implement this method.  This deserves further clarification. Wha

Re: [Proposal/Question] Provide mechanism to monitor thread states more efficiently

2017-10-27 Thread mandy chung
serviceability-dev is the mailing list for discussing java.lang.management APIs. Getting the stack trace is expensive. ThreadMXBean.getThreadInfos(ids) does not get the stack trace and locks information and is less expensive. A typical lightweight monitoring application does BCI and call Thr

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

2017-10-27 Thread mandy chung
On 10/26/17 8:57 PM, Harsha Wardhana B wrote: Hi, Below is the updated webrev incorporating review comments from Daniel, Roger and Mandy. The password file will now be locked before writing. What is the link to the new webrev? Mandy, 49 # https://docs.oracle.com/javase/7/docs/technot

Re: RFR: SA: JDK-8189798: SA cleanup - part 1

2017-10-27 Thread Jini George
Thank you very much, Serguei. -Jini. On 10/27/2017 2:22 PM, serguei.spit...@oracle.com wrote: Hi Jini, The fix looks good to me. Thanks, Serguei On 10/24/17 00:31, Jini George wrote: Adding hotspot-dev too. Thanks, Jini. On 10/24/2017 12:05 PM, Jini George wrote: Hello, As a part of SA

RE: RFR(S): 8189368: Add information on current bias holder for BiasedLockRevocation event

2017-10-27 Thread Markus Gronlund
Hi Robin, Looks good, thanks for adding this information to the event. Cheers Markus -Original Message- From: Robin Westberg Sent: den 25 oktober 2017 15:52 To: serviceability-dev@openjdk.java.net Subject: RFR(S): 8189368: Add information on current bias holder for BiasedLockRevocation

Re: RFR(S): 8189368: Add information on current bias holder for BiasedLockRevocation event

2017-10-27 Thread Robin Westberg
Hi Erik, Thanks for reviewing! Best regards, Robin > On 26 Oct 2017, at 18:50, Erik Gahlin wrote: > > Looks good. > > Erik >> Hi all, >> >> Please review the following changes which add a new field to the >> BiasedLockRevocation event, previousOwner, containing information on which >> thre

Re: RFR(S): 8189368: Add information on current bias holder for BiasedLockRevocation event

2017-10-27 Thread Robin Westberg
Hi David, Thanks for taking a look! > On 27 Oct 2017, at 12:13, David Holmes wrote: > > Hi Robin, > > On 25/10/2017 11:52 PM, Robin Westberg wrote: >> Hi all, >> Please review the following changes which add a new field to the >> BiasedLockRevocation event, previousOwner, containing informati

Re: [PATCH] Unnecessary Amount Of Internal Class Conversion

2017-10-27 Thread serguei.spit...@oracle.com
Let's check if Alan has a time to look at it. The patch is not that big. Thanks, Serguei On 10/27/17 03:35, Ben Walsh wrote: Excellent. Thanks Serguei. That's correct. It's my first contribution. Could you recommend someone for the second required review ? Thanks, Ben Walsh -"serguei.

Re: [PATCH] Unnecessary Amount Of Internal Class Conversion

2017-10-27 Thread Ben Walsh
Excellent. Thanks Serguei. That's correct. It's my first contribution. Could you recommend someone for the second required review ? Thanks, Ben Walsh -"serguei.spit...@oracle.com" wrote: - To: Ben Walsh , serviceability-dev@openjdk.java.net From: "serguei.spit...@oracle.com" Date: 27

Re: RFR(S): 8189368: Add information on current bias holder for BiasedLockRevocation event

2017-10-27 Thread David Holmes
Hi Robin, On 25/10/2017 11:52 PM, Robin Westberg wrote: Hi all, Please review the following changes which add a new field to the BiasedLockRevocation event, previousOwner, containing information on which thread (if any) owned the bias before it was revoked. So to be clear the previous bias

Re: RFR: SA: JDK-8189798: SA cleanup - part 1

2017-10-27 Thread serguei.spit...@oracle.com
Hi Jini, The fix looks good to me. Thanks, Serguei On 10/24/17 00:31, Jini George wrote: Adding hotspot-dev too. Thanks, Jini. On 10/24/2017 12:05 PM, Jini George wrote: Hello, As a part of SA next, I am working on writing a test case which compares the fields and the types of the fields