RE: [8u] RFR for backport of JDK-8177721: Improve diagnostics in sun.management.Agent#startAgent()

Thank you David. Regards, Shafi > -Original Message- > From: David Holmes > Sent: Thursday, November 02, 2017 11:55 AM > To: Shafi Ahmad ; Daniel Fuchs > ; serviceability-dev@openjdk.java.net > Subject: Re: [8u] RFR for backport of JDK-8177721: Improve diagnostics in > sun.management.Agen

Re: [8u] RFR for backport of JDK-8177721: Improve diagnostics in sun.management.Agent#startAgent()

On 2/11/2017 4:19 PM, Shafi Ahmad wrote: Hi All, May get the second review for this backport. Not sure a second one is needed for a backport like this, but I concur with Daniel that the changes match the original changeset. :) Thanks, David Regards, Shafi -Original Message- From

RE: [8u] RFR for backport of JDK-8177721: Improve diagnostics in sun.management.Agent#startAgent()

Hi All, May get the second review for this backport. Regards, Shafi > -Original Message- > From: Daniel Fuchs > Sent: Wednesday, October 25, 2017 2:34 PM > To: Shafi Ahmad ; serviceability- > d...@openjdk.java.net > Cc: David Holmes > Subject: Re: [8u] RFR for backport of JDK-8177721: I

Re: RFR: SA: JDK-8189798: SA cleanup - part 1

Could I please get one more review done for this ? Thanks, Jini. On 10/27/2017 9:19 PM, Jini George wrote: Thank you very much, Serguei. -Jini. On 10/27/2017 2:22 PM, serguei.spit...@oracle.com wrote: Hi Jini, The fix looks good to me. Thanks, Serguei On 10/24/17 00:31, Jini George wrote

Re: RFR: 8183542: Factor out serial GC specific code from GenCollectedHeap into its own subclass

> On Oct 25, 2017, at 4:07 AM, Roman Kennke wrote: > > Hi Kim, hi Jini, > > thank you both for your reviews! > > I think I need a sponsor now. The final webrev (same as before plus > Reviewed-by line): > http://cr.openjdk.java.net/~rkennke/8183542/webrev.03/ >

Re: RFR (S): 8187289 NotifyFramePop request is not cleared if JVMTI_EVENT_FRAME_POP is disabled

PING.. Thanks, Serguei On 10/12/17 21:58, serguei.spit...@oracle.com wrote: Please, review a fix for:   https://bugs.openjdk.java.net/browse/JDK-8187289 Webrev:   http://cr.openjdk.java.net/~sspi

Re: Low-Overhead Heap Profiling

Dear all, Here is the next webrev: http://cr.openjdk.java.net/~rasbold/8171119/webrev.14a/ Incremental since the rebase: http://cr.openjdk.java.net/~rasbold/8171119/webrev.14_14a/ (I'm still not too familiar with hg so I had to do a fresh rebase so v14 is once the rebase was done and v14a integr

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

On 31/10/2017 17:07, mandy chung wrote: On 10/31/17 8:55 AM, Harsha Wardhana B wrote: Hi Mandy, Below is the new webrev incorporating below review comments. http://cr.openjdk.java.net/~hb/5016517/webrev.06/ Looks okay in general except this: 286 // Check if header needs to be ins

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

Hi Harsha, Sorry for the late editorial recommendations: In jmxremote.password.template: 41: "Clear text" -> "A clear text" 43: 'below format" -> "format below" 53: "in clear" -> "in the clear" 63: "in clear" -> "in the clear" 77: "by ONLY the owner" -> "ONLY by the owner" 80-81: Is not consist

PING: RFR: JDK-8153333: [REDO] STW phases at Concurrent GC should count in PerfCounter

PING: Could you review and sponsor it? http://cr.openjdk.java.net/~ysuenaga/JDK-815/webrev.04/ Also I need JPRT results of this change. Could you cooperate? Thanks, Yasumasa On 2017/09/27 0:08, Yasumasa Suenaga wrote: Hi all, I uploaded new webrev to be adapted to jdk10/hs:   h

PING: RFR: 8165736: Error message should be shown when JVMTI agent cannot be attached

PING: Could you review and sponsor it? http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.00/ Thanks, Yasumasa On 2017/09/29 13:24, Yasumasa Suenaga wrote: Hi all, If we try to attach invalid JVMTI agent via JVMTI.agent_load dcmd, we will get "Command executed successfully". Howe

PING: RFR: 8185796: jstack and clhsdb jstack should show lock objects

PING: Could you review and sponsor it? http://cr.openjdk.java.net/~ysuenaga/JDK-8185796/webrev.03/ Thanks, Yasumasa On 2017/10/09 23:19, Yasumasa Suenaga wrote: Hi all, I uploaded new webrev to be adapted to current jdk10/hs:   http://cr.openjdk.java.net/~ysuenaga/JDK-8185796/webrev