RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException

I have made minor modification to the test (added @bug and removed @modules). The revised webrev is http://cr.openjdk.java.net/~sballal/8184982/webrev.01/ Thanks, Sharath From: Sharath Ballal Sent: Tuesday, November 21, 2017 12:27 PM To: serviceability-dev@openjdk.java.net Sub

RFR: JDK-8191324: SA cleanup -- part 2

Hello, Here's requesting reviews for some SA code cleanup. ID: https://bugs.openjdk.java.net/browse/JDK-8191324 Webrev: http://cr.openjdk.java.net/~jgeorge/8191324/webrev.00/index.html The changes here are primarily to: 1. Remove unused IA64 SA code. 2. Make changes to avoid error-prone redefi

Re: RFR: 8191564: Refactor GC related servicability code into GC specific subclasses

Currently, there's lots of GC specific code sprinkled over src/hotspot/share/services. This change introduces a GC interface for that, and moves all GC specific code to their respective src/hotspot/share/gc directory. http://cr.openjdk.java.net/~rkennke/8191564/webrev.00/

Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException

+1 -Sundar On 21/11/17, 12:26 PM, Sharath Ballal wrote: Gentle reminder. Thanks, Sharath *From:* Sharath Ballal *Sent:* Tuesday, November 14, 2017 10:31 AM *To:* serviceability-dev@openjdk.java.net *Subject:* RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullP

Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException

+1 -Sundar On 21/11/17, 3:26 PM, Sharath Ballal wrote: I have made minor modification to the test (added @bug and removed @modules). The revised webrev is http://cr.openjdk.java.net/~sballal/8184982/webrev.01/ Thanks, Sharath

Re: RFR(XL): 8167108 - SMR and JavaThread Lifecycle

Hi Robin W! Welcome to the Thread-SMR party!! On 11/20/17 4:48 AM, Robin Westberg wrote: Hi Dan, Overall I must say this looks very nice, can’t wait to use it! (Also a disclaimer: not a reviewer, and have not looked at the gc or jmvti specific changes nor the tests (yet)). Code reviews are

Re: PING: RFR: 8165736: Error message should be shown when JVMTI agent cannot be attached

Hi Serguei, On 2017/11/21 16:17, serguei.spit...@oracle.com wrote: Hi Yasumasa, Thank you for the update. Some comments. http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.04/src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java.frames.html 94 BufferedReader reader =

RFR: JDK-8191658 - SA: Testcases for attach, detach, reattach and Jhisto commands

Hello, Pls review changes for the following issue: Bug ID: https://bugs.openjdk.java.net/browse/JDK-8191658 Webrev: http://cr.openjdk.java.net/~sballal/8191658/webrev.00/ Thanks, Sharath

Re: RFR(XL): 8167108 - SMR and JavaThread Lifecycle

Hi Coleen! Thanks for making time to review the Thread-SMR stuff again!! I have added back the other three OpenJDK aliases... This review is being done on _four_ different OpenJDK aliases. As always, replies are embedded below... On 11/20/17 3:12 PM, coleen.phillim...@oracle.com wrote: http

Re: RFR(XL): 8167108 - SMR and JavaThread Lifecycle

On 11/21/17 11:28 AM, Daniel D. Daugherty wrote: Hi Coleen! Thanks for making time to review the Thread-SMR stuff again!! I have added back the other three OpenJDK aliases... This review is being done on _four_ different OpenJDK aliases. As always, replies are embedded below... On 11/20/17

Re: RFR(XL): 8167108 - SMR and JavaThread Lifecycle

Adding back the missing OpenJDK aliases... On 11/21/17 11:14 AM, coleen.phillim...@oracle.com wrote: On 11/20/17 8:50 PM, Daniel D. Daugherty wrote: On 11/20/17 12:51 AM, David Holmes wrote: Hi Dan, Figured I'd better cast an eye over this again before it gets pushed :) Thanks for review

Re: RFR(XL): 8167108 - SMR and JavaThread Lifecycle

Thanks for keeping all the OpenJDK aliases! On 11/21/17 12:24 PM, coleen.phillim...@oracle.com wrote: On 11/21/17 11:28 AM, Daniel D. Daugherty wrote: Hi Coleen! Thanks for making time to review the Thread-SMR stuff again!! I have added back the other three OpenJDK aliases... This review i

Re: RFR: 8191564: Refactor GC related servicability code into GC specific subclasses

I had some off-band discussions with Erik Helin and re-did most of the changeset: - The GC interface now resides in CollectedHeap, specifically the two methods memory_managers() and memory_pools(), and is implemented in the various concrete subclasses. - Both methods return (by value) a Growable

Re: RFR(XL): 8167108 - SMR and JavaThread Lifecycle

Greetings, *** We are wrapping up code review on this project so it is time *** *** for the various code reviewers to chime in one last time. *** In this latest round, we had three different reviewers chime in so we're doing delta webrevs for each of those resolutions: David H's resolutions: h

Re: RFR(XL): 8167108 - SMR and JavaThread Lifecycle

Hi Dan, On 22/11/2017 10:12 AM, Daniel D. Daugherty wrote: Greetings, *** We are wrapping up code review on this project so it is time *** *** for the various code reviewers to chime in one last time. *** In this latest round, we had three different reviewers chime in so we're doing delta webr

RE: RFR: 8189102: All tools should support -?, -h and --help

Hi Max, while removing the comments from the k-tools, I saw this: --- a/src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Klist.java Tue Oct 10 14:39:45 2017 +0200 +++ b/src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Klist.java Tue

Re: RFR: 8189102: All tools should support -?, -h and --help

Hi Goetz I would just remove it. Thanks Max > On Nov 22, 2017, at 2:53 PM, Lindenmaier, Goetz > wrote: > > Hi Max, > > while removing the comments from the k-tools, I saw this: > > --- > a/src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Klist.java > Tue Oct 1

RE: RFR: 8189102: All tools should support -?, -h and --help

OK, thanks! Best regards, Goetz. > -Original Message- > From: Weijun Wang [mailto:weijun.w...@oracle.com] > Sent: Wednesday, November 22, 2017 8:08 AM > To: Lindenmaier, Goetz > Cc: core-libs-...@openjdk.java.net; compiler-...@openjdk.java.net; > serviceability-dev (serviceability-dev@