[8u] RFR(S) 8059036: Implement Diagnostic Commands for heap and finalizerinfo

2017-12-14 Thread David Buck
Hi! May I please get a review of the following very simple backport of this serviceability improvement to JDK 8? The two hotspot jtreg test cases needed to be modified slightly because of the lack of dcmd-specific test support in JDK 8's HS code base. The only non-test difference from the JD

RE: RFR: JDK-8193427 - serviceability/sa/ClhsdbPrintStatics.java fails: java.lang.RuntimeException: '_jfr_checkpoints' missing from stdout/stderr

2017-12-14 Thread Sharath Ballal
Thank you for the review Serguei.     Thanks, Sharath     From: Serguei Spitsyn Sent: Thursday, December 14, 2017 10:54 PM To: Sharath Ballal; serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8193427 - serviceability/sa/ClhsdbPrintStatics.java fails: java.lang.RuntimeException: '_

RE: RFR: JDK-8193428 - serviceability/sa/ClhsdbSymbol.java fails: java.lang.RuntimeException: 'UsageTracker' missing from stdout/stderr

2017-12-14 Thread Sharath Ballal
Thank you for the review Serguei.     Thanks, Sharath     From: Serguei Spitsyn Sent: Thursday, December 14, 2017 10:55 PM To: Sharath Ballal; serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8193428 - serviceability/sa/ClhsdbSymbol.java fails: java.lang.RuntimeException: 'UsageTr

Re: [10] RFR for JDK-8170299: Debugger does not stop inside the low memory notifications code [internal]

2017-12-14 Thread David Holmes
On 13/12/2017 8:23 PM, Shafi Ahmad wrote: Thank you Mandy and David for review comments. Please find updated webrev: http://cr.openjdk.java.net/~shshahma/8170299/webrev.03/ I have modify the code to use Emitter class rather than Broadcaster. Okay. This at least seems less intrusive/disrupti

Re: RFR: JDK-8193428 - serviceability/sa/ClhsdbSymbol.java fails: java.lang.RuntimeException: 'UsageTracker' missing from stdout/stderr

2017-12-14 Thread serguei.spit...@oracle.com
Looks fine too. Thanks, Serguei On 12/14/17 02:12, Sharath Ballal wrote: Hello,   Requesting reviews for:   JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193428

Re: RFR: JDK-8193427 - serviceability/sa/ClhsdbPrintStatics.java fails: java.lang.RuntimeException: '_jfr_checkpoints' missing from stdout/stderr

2017-12-14 Thread serguei.spit...@oracle.com
Hi Sharath, Looks fine. Thanks, Serguei On 12/14/17 02:12, Sharath Ballal wrote:   Hello,   Requesting reviews for:   JBS Id: https://bugs.openjdk.java.net/brow

RE: RFR: JDK-8193428 - serviceability/sa/ClhsdbSymbol.java fails: java.lang.RuntimeException: 'UsageTracker' missing from stdout/stderr

2017-12-14 Thread Sharath Ballal
Thank you David. Can I have one more review pls? Thanks, Sharath -Original Message- From: David Holmes Sent: Thursday, December 14, 2017 5:45 PM To: Sharath Ballal; serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8193428 - serviceability/sa/ClhsdbSymbol.java fails: java.lang

RE: RFR: JDK-8193427 - serviceability/sa/ClhsdbPrintStatics.java fails: java.lang.RuntimeException: '_jfr_checkpoints' missing from stdout/stderr

2017-12-14 Thread Sharath Ballal
Thank you David. Can I have one more review pls? Thanks, Sharath -Original Message- From: David Holmes Sent: Thursday, December 14, 2017 5:44 PM To: Sharath Ballal; serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8193427 - serviceability/sa/ClhsdbPrintStatics.java fails: jav

Re: RFR: JDK-8193428 - serviceability/sa/ClhsdbSymbol.java fails: java.lang.RuntimeException: 'UsageTracker' missing from stdout/stderr

2017-12-14 Thread David Holmes
Looks fine. Thanks, David On 14/12/2017 8:12 PM, Sharath Ballal wrote: Hello, Requesting reviews for: JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193428 Webrev: http://cr.openjdk.java.net/~sballal/8193428/webrev.00/ I tested the changes in an open only workspace.  Also the test ran s

Re: RFR: JDK-8193427 - serviceability/sa/ClhsdbPrintStatics.java fails: java.lang.RuntimeException: '_jfr_checkpoints' missing from stdout/stderr

2017-12-14 Thread David Holmes
Looks fine. Thanks, David On 14/12/2017 8:12 PM, Sharath Ballal wrote: Hello, Requesting reviews for: JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193427 Webrev: http://cr.openjdk.java.net/~sballal/8193427/webrev.00/ I tested the changes in an open only workspace.  Also the test ran s

RFR: JDK-8193428 - serviceability/sa/ClhsdbSymbol.java fails: java.lang.RuntimeException: 'UsageTracker' missing from stdout/stderr

2017-12-14 Thread Sharath Ballal
Hello, Requesting reviews for: JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193428 Webrev: http://cr.openjdk.java.net/~sballal/8193428/webrev.00/ I tested the changes in an open only workspace. Also the test ran successfully in JPRT and Mach5. Thanks, Sharath

RFR: JDK-8193427 - serviceability/sa/ClhsdbPrintStatics.java fails: java.lang.RuntimeException: '_jfr_checkpoints' missing from stdout/stderr

2017-12-14 Thread Sharath Ballal
Hello, Requesting reviews for: JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193427 Webrev: http://cr.openjdk.java.net/~sballal/8193427/webrev.00/ I tested the changes in an open only workspace. Also the test ran successfully in JPRT and Mach5. Thanks, Sharath