Chris pointed out, there is no point to run the tier5.
It is enough to run the :jdk_instrument.
Thanks,
Serguei
On 12/19/17 17:26, serguei.spit...@oracle.com wrote:
Gary,
What tests did you run?
Event though the fix looks save it is still a good idea to submit a
mach5 job that includes the :
Gary,
What tests did you run?
Event though the fix looks save it is still a good idea to submit a
mach5 job that includes the :jdk_instrument test suite. Most likely, it
is in the hs-tier5 (or more specifically, hs-tier5-rt)
Thanks,
Serguei
On 12/19/17 14:50, Chris Plummer wrote:
I can push
I can push it this evening if no one else grabs it first (need to step
out for a bit and won't be able to monitor CI results). Please produce a
changeset first.
thanks,
Chris
On 12/19/17 2:47 PM, gary.ad...@oracle.com wrote:
Now comes the catch ...
I'll need a sponsor.
On 12/19/17 5:12
Now comes the catch ...
I'll need a sponsor.
On 12/19/17 5:12 PM, Chris Plummer wrote:
+1
Thanks, Chris
On 12/19/17 8:57 AM, serguei.spit...@oracle.com wrote:
Looks good.
Thanks, Serguei
On 12/19/17 06:58, Gary Adams wrote:
A refreshed webrev is vailable
Webrev: http://cr.openjdk.ja
More work is needed here. I have not tracked down how detach is actually
used.
The previous path as null string was a flag to reconnect (?).
On 12/19/17 5:23 PM, Chris Plummer wrote:
Hi Gary,
I'm not sure about the detach() and execute() changes on linux (how
can this.path references just be
Hi Gary,
I'm not sure about the detach() and execute() changes on linux (how can
this.path references just be stripped and the code still work properly),
and how does this code continue to work on AIX and MacOSX when "path"
has been removed but is still referenced. Shouldn't this.path just be
+1
Thanks, Chris
On 12/19/17 8:57 AM, serguei.spit...@oracle.com wrote:
Looks good.
Thanks, Serguei
On 12/19/17 06:58, Gary Adams wrote:
A refreshed webrev is vailable
Webrev: http://cr.openjdk.java.net/~gadams/8180709/webrev.01/
On 12/19/17, 5:10 AM, Alan Bateman wrote:
On 18/12/2017 2
Looks good.
Thanks, Serguei
On 12/19/17 06:58, Gary Adams wrote:
A refreshed webrev is vailable
Webrev: http://cr.openjdk.java.net/~gadams/8180709/webrev.01/
On 12/19/17, 5:10 AM, Alan Bateman wrote:
On 18/12/2017 21:14, gary.ad...@oracle.com wrote:
I can just the error message.
What woul
A refreshed webrev is available
Webrev: http://cr.openjdk.java.net/~gadams/8188856/webrev.01/
On 12/18/17, 4:38 PM, Chris Plummer wrote:
On 12/18/17 1:22 PM, gary.ad...@oracle.com wrote:
On 12/18/17 2:26 PM, Chris Plummer wrote:
Hi Gary,
On 12/18/17 6:47 AM, Gary Adams wrote:
Here's a sim
A refreshed webrev is vailable
Webrev: http://cr.openjdk.java.net/~gadams/8180709/webrev.01/
On 12/19/17, 5:10 AM, Alan Bateman wrote:
On 18/12/2017 21:14, gary.ad...@oracle.com wrote:
I can just the error message.
What would you like it to say?
"Module java.instrument may be missing"
Techni
On 12/18/17, 4:38 PM, Chris Plummer wrote:
On 12/18/17 1:22 PM, gary.ad...@oracle.com wrote:
On 12/18/17 2:26 PM, Chris Plummer wrote:
Hi Gary,
On 12/18/17 6:47 AM, Gary Adams wrote:
Here's a simple fix to correct the error message when the java_pid
socket
is not found. The code previously r
On 18/12/2017 21:14, gary.ad...@oracle.com wrote:
I can just the error message.
What would you like it to say?
"Module java.instrument may be missing"
Technically it may be that the java.instrument module is not observable
but saying that it may not be in the run-time image is probably clearer
Hi!
Please review this straightforward serviceability backport to JDK 8.
No real changes to product code. I just moved the import statements in
the DynLibDcmdTest.java test case to below the copyright header.
bug report:
https://bugs.openjdk.java.net/browse/JDK-8031304
JDK 9 review thread:
h
13 matches
Mail list logo
