[8u] RFR(S) 8044107 : Add Diagnostic Command to list all ClassLoaders

2017-12-21 Thread David Buck
Hi! Please review this very simple serviceability backport to 8u. The only difference between the JDK 9 changeset and the JDK 8 changeset is that the ClassLoaderDataGraph::cld_do function was already backported to JDK 8 in the fix for 8049421 [0]. So the changes for adding classLoaderData.hpp

Re: RFR: JDK-8188856: Incorrect file path in an exception message when .java_pid is not accessible on Unix

2017-12-21 Thread serguei.spit...@oracle.com
One more suggestion. I like the linux variant which keeps the findSocketFile() method. Would it better to unify things and do the same for aix and macosx? Thanks, Serguei On 12/21/17 15:37, serguei.spit...@oracle.com wrote:

Re: RFR: JDK-8188856: Incorrect file path in an exception message when .java_pid is not accessible on Unix

2017-12-21 Thread serguei.spit...@oracle.com
Hi Gary, +File path = new File(tmpdir, ".java_pid" + pid); The path is better to rename to file now. Otherwise, it is a source of confusion. A couple of minor comments on the:   http://cr.openjdk.java.net/~gadams/8188856/webrev.0

Re: RFR: JDK-8188856: Incorrect file path in an exception message when .java_pid is not accessible on Unix

2017-12-21 Thread Gary Adams
A refreshed webrev is available Webrev: http://cr.openjdk.java.net/~gadams/8188856/webrev.02/ - added solaris version of the file which had the same original error reporting the wrong socket file name - restored the linux detach/execute logic - updated the macosx and aix detach/e