Re: RFR: cleanup - removed unneeded casts in jdi

2017-12-22 Thread David Holmes
Hi Egor, On 23/12/2017 1:32 AM, Egor Ushakov wrote: Hi all, could you please review and sponsor this small cleanup removing unneeded casts in jdi LocationImpl and MirrorImpl. They were preventing creating custom Location and Mirror implementations used for tests and IDEA debugger impl. http:

Re: DOC RFR: 8187448: 360 doc issues in jdwp-protocol.html

2017-12-22 Thread serguei.spit...@oracle.com
Hi Daniil, The fix looks good to me. Thank you for taking care about this! Thanks, Serguei On 12/22/17 09:39, Daniil Titov wrote: Please review a fix for the doc bug. The fix does the following: 1. Removes empty elements. 2. Adds an outer element to the in

Re: RFR: JDK-8188856: Incorrect file path in an exception message when .java_pid is not accessible on Unix

2017-12-22 Thread serguei.spit...@oracle.com
Gary, The fix looks good. Thank you for the update! On 12/22/17 07:48, Gary Adams wrote: A refreshed webrev is available     Webrev: http://cr.openjdk.java.net/~gadams/8188856/webrev.03/  - "String socket_path" is now used where the original "path" variable was used  - "File socket_file" is

DOC RFR: 8187448: 360 doc issues in jdwp-protocol.html

2017-12-22 Thread Daniil Titov
Please review a fix for the doc bug. The fix does the following: 1. Removes empty elements. 2. Adds an outer element to the index section . 3. Removes obsolete in HTML5 “summary” attribute in elements. 4. Removes empty elements. 5. Replaces n

Re: RFR: JDK-8188856: Incorrect file path in an exception message when .java_pid is not accessible on Unix

2017-12-22 Thread Gary Adams
A refreshed webrev is available Webrev: http://cr.openjdk.java.net/~gadams/8188856/webrev.03/ - "String socket_path" is now used where the original "path" variable was used - "File socket_file" is used for the exists() and getPath() calls - left solaris openDoor optimizations out, becaus

RFR: cleanup - removed unneeded casts in jdi

2017-12-22 Thread Egor Ushakov
Hi all, could you please review and sponsor this small cleanup removing unneeded casts in jdi LocationImpl and MirrorImpl. They were preventing creating custom Location and Mirror implementations used for tests and IDEA debugger impl. http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix/ I d

Re: [8u] RFR(S) 8044107 : Add Diagnostic Command to list all ClassLoaders

2017-12-22 Thread David Holmes
This looks like an accurate backport to me. Thanks, David On 22/12/2017 4:19 PM, David Buck wrote: Hi! Please review this very simple serviceability backport to 8u. The only difference between the JDK 9 changeset and the JDK 8 changeset is that the ClassLoaderDataGraph::cld_do function was a