Re: Another question regarding Thread dumps

On 13/03/2018 1:41 AM, Langer, Christoph wrote: Hi, I have another question regarding thread dumping code. At the places where thread dumps get generated (attachListener.cpp, diagnosticCommand.cpp, os.cpp), there's always a series of 3 VM operations: VM_PrintThreads, VM_PrintJNI and VM_FindDe

Re: RFR: JDK-8175312: SA: clhsdb: Provide an improved heap summary for 'universe' for G1GC

Jini, Looks good. One minor comment: + public void printG1HeapSummary(G1CollectedHeap heap) {+ G1CollectedHeap g1h = (G1CollectedHeap) heap; 'heap' has been cast to 'G1CollectedHeap' at call site, so seems no need to convert here again. Thanks Yumin On Mon, Mar 12, 2018 at 8:52 AM, Jini

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Igor, On 3/12/18 1:26 PM, Igor Ignatyev wrote: On Mar 12, 2018, at 8:53 AM, Chris Plummer > wrote: On 3/11/18 7:52 PM, David Holmes wrote: Hi Chris, On 10/03/2018 6:46 AM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.open

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

> On Mar 12, 2018, at 8:53 AM, Chris Plummer wrote: > > On 3/11/18 7:52 PM, David Holmes wrote: >> Hi Chris, >> >> On 10/03/2018 6:46 AM, Chris Plummer wrote: >>> Hello, >>> >>> Please help review the following: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8198655 >>> http://cr.openjdk.j

Re: PING: Re: RFR: JDK-8193369: post_field_access does not work for some functions, possibly related to fast_getfield

Hi Alex, Please update the copyright date in jvmtiManageCapabilities.cpp. The following is where you added your fix:  315   if (avail.can_generate_breakpoint_events  316    || avail.can_generate_field_access_events  317    || avail.can_generate_field_modification_events)  318   {  319  

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

On 3/11/18 7:52 PM, David Holmes wrote: Hi Chris, On 10/03/2018 6:46 AM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8198655 http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/ In the end there were two issues. The first

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

On 3/12/18 3:27 AM, Langer, Christoph wrote: Hi Chris, Hi Chris, On 10/03/2018 6:46 AM, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8198655 http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/ In the end there were two i

Re: RFR: JDK-8175312: SA: clhsdb: Provide an improved heap summary for 'universe' for G1GC

Thank you very much, Stefan. Could one more reviewer please take a look at it ? - Jini. On 3/12/2018 8:52 PM, Stefan Johansson wrote: Hi Jini, This looks good. I'm totally fine with skipping metaspace if that isn't displayed for the other GCs. Cheers, Stefan On 2018-03-09 10:29, Jini Geor

Another question regarding Thread dumps

Hi, I have another question regarding thread dumping code. At the places where thread dumps get generated (attachListener.cpp, diagnosticCommand.cpp, os.cpp), there's always a series of 3 VM operations: VM_PrintThreads, VM_PrintJNI and VM_FindDeadlocks. I'm wondering if it would make sense to

Re: RFR: JDK-8175312: SA: clhsdb: Provide an improved heap summary for 'universe' for G1GC

Hi Jini, This looks good. I'm totally fine with skipping metaspace if that isn't displayed for the other GCs. Cheers, Stefan On 2018-03-09 10:29, Jini George wrote: Here is the revised webrev: http://cr.openjdk.java.net/~jgeorge/8175312/webrev.02/ I have made modifications to have the 'uni

Re: RFR: 8199323: hsdis could not be loaded which are located on long path

Hi David, I don't think this code has the same concern that the code in jvm_md.h claims** to have, so a simple use of MAXPATHLEN should be fine on all non-windows platforms. It sounds good to me. I updated webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8199323/webrev.01/ My only conce

RE: RFR (XS): 8199010: attachListener.hpp: Fix potential null termination issue found by coverity scans

Hi, here is the final webrev for pushing: http://cr.openjdk.java.net/~clanger/webrevs/8199010.2/ I also did a little sorting in the include files (alphabetical order). The tests at SAP went fine and the coverity build was satisfied, too 😊 Thanks in advance, Chris, for sponsoring. Best regards

RE: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Chris, > Hi Chris, > > On 10/03/2018 6:46 AM, Chris Plummer wrote: > > Hello, > > > > Please help review the following: > > > > https://bugs.openjdk.java.net/browse/JDK-8198655 > > http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/ > > > > In the end there were two issues. The fir

tt