Re: RFR: 8049695: nsk/jdb/options/connect/connect003 fails with "Launched jdb could not attach to debuggee during 300000 milliseconds"

2018-03-20 Thread David Holmes
Hi Alex, On 21/03/2018 3:25 AM, Alex Menkov wrote: Hi David, On 03/19/2018 18:10, David Holmes wrote: Hi Alex, On 20/03/2018 10:28 AM, Alex Menkov wrote: Hi guys, please re-review the fix. I still have an unanswered question about where the max of 49 is enforced. I see it for the

Re: RFR(S): 8195109: ServiceUtil::visible_oop is not needed anymore

2018-03-20 Thread Chris Plummer
Hi, New webrev: http://cr.openjdk.java.net/~cjplummer/8195109/webrev.01/index.html There was a build failure on solaris-sparc in threadSMR.cpp. References to the Copy class were producing "unresolved symbol" errors. threadSMR.cpp includes threadService.hpp, which no longer includes

Re: RFR: 8049695: nsk/jdb/options/connect/connect003 fails with "Launched jdb could not attach to debuggee during 300000 milliseconds"

2018-03-20 Thread Alex Menkov
Hi David, On 03/19/2018 18:10, David Holmes wrote: Hi Alex, On 20/03/2018 10:28 AM, Alex Menkov wrote: Hi guys, please re-review the fix. I still have an unanswered question about where the max of 49 is enforced. I see it for the "address" but not names in general. ?? for shmem the

Re: RFR: JDK-8199682 Clean up building the saproc library

2018-03-20 Thread Sundararajan Athijegannathan
Hi, Sounds good - so long as we don't have scripts that depend on the old name. Or if those could be fixed... -Sundar On 20/03/18, 4:54 PM, Magnus Ihse Bursie wrote: On 2018-03-16 19:12, Magnus Ihse Bursie wrote: Hi Sundar, I almost missed your mail, since you removed both me and

Re: RFR: JDK-8199682 Clean up building the saproc library

2018-03-20 Thread Magnus Ihse Bursie
On 2018-03-16 19:12, Magnus Ihse Bursie wrote: Hi Sundar, I almost missed your mail, since you removed both me and build-dev from the cc list... 16 mars 2018 kl. 06:14 skrev Sundararajan Athijegannathan : Renaming sawindbg as saproc sounds odd. For

Re: RFR(S): 8195109: ServiceUtil::visible_oop is not needed anymore

2018-03-20 Thread Stefan Karlsson
Looks good to me. StefanK On 2018-03-20 01:48, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8195109 http://cr.openjdk.java.net/~cjplummer/8195109/webrev.00/index.html The assert I added to make sure this is safe has been in place in