Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

On Wed, Mar 28, 2018 at 3:14 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-03-28 23:53, Martin Buchholz wrote: > > I can't find any documentation for what JNIEXPORT and friends actually do. > People including myself have been cargo-culting JNIEXPORT and JNICALL for > dec

Re: RFR(xxs): 8200384: jcmd help output should be sorted

Re-directing to serviceability-dev. David On 29/03/2018 6:08 AM, Thomas Stüfe wrote: Hi all, may I get reviews for this tiny trivial change which causes jcmd help output (the command list) to be sorted? bug: https://bugs.openjdk.java.net/browse/JDK-8200384 webrev: http://cr.openjdk.java.net/~

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

On 2018-03-28 23:53, Martin Buchholz wrote: I can't find any documentation for what JNIEXPORT and friends actually do. People including myself have been cargo-culting JNIEXPORT and JNICALL for decades. Why aren't they in the JNI spec? That surprises me. I'm quite certain that javah (or rather,

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

I can't find any documentation for what JNIEXPORT and friends actually do. People including myself have been cargo-culting JNIEXPORT and JNICALL for decades. Why aren't they in the JNI spec? --- It's fishy that the attribute externally_visible (which seems very interesting!) is ARM specific. #

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

Build changes still look good to me. /Erik On 2018-03-28 03:31, Magnus Ihse Bursie wrote: On 2018-03-28 01:52, Weijun Wang wrote: On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie wrote: https://bugs.openjdk.java.net/browse/JDK-8200193 -- for jdk.security.auth There is only one function t

Re: RFR: 8199519: Several GC tests fails with: java.lang.NumberFormatException: Unparseable number: "-"

Mach5 testing looks good. Can someone in the serviceability team do the second review? Cheers, Stefan On 2018-03-28 13:32, Yasumasa Suenaga wrote: Thanks Stefan, I'm waiting for second reviewer. Yasumasa 2018年3月28日(水) 18:36 Stefan Johansson >: Hi Y

Re: RFR: 8199519: Several GC tests fails with: java.lang.NumberFormatException: Unparseable number: "-"

Thanks Stefan, I'm waiting for second reviewer. Yasumasa 2018年3月28日(水) 18:36 Stefan Johansson : > Hi Yasumasa, > > Local testing looks good and I've kicked of some additional Mach5 > testing that will include these tests on all platforms. > > Cheers, > Stefan > > On 2018-03-28 06:04, Yasumasa

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

On 2018-03-28 01:52, Weijun Wang wrote: On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie wrote: https://bugs.openjdk.java.net/browse/JDK-8200193 -- for jdk.security.auth There is only one function to export and it already has JNIEXPORT, so you can just remove the new $(LIBJAAS_CFLAGS) [1].

Re: RFR: 8199519: Several GC tests fails with: java.lang.NumberFormatException: Unparseable number: "-"

Hi Yasumasa, Local testing looks good and I've kicked of some additional Mach5 testing that will include these tests on all platforms. Cheers, Stefan On 2018-03-28 06:04, Yasumasa Suenaga wrote: Hi Stefan, Thank you for sharing your report! I could reproduce them on my VM. I've fixed them