Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Thank you, Yasumasa. - Jini. On 4/26/2018 11:41 AM, Yasumasa Suenaga wrote: Hi Jini, I have no further comment. Yasumasa 2018-04-26 13:21 GMT+09:00 Jini George : Thank you, Yasumasa. I hope to implement the consolidation with TestSAServer.java (and have the SA core file debug testing tem

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Hi Jini, I have no further comment. Yasumasa 2018-04-26 13:21 GMT+09:00 Jini George : > Thank you, Yasumasa. I hope to implement the consolidation with > TestSAServer.java (and have the SA core file debug testing template done) as > a part of a separate enhancement: > https://bugs.openjdk.jav

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Many thanks, David! - Jini. On 4/26/2018 10:27 AM, David Holmes wrote: Thanks Jini, I have no further comments as the tests "passed" for me. David On 25/04/2018 1:26 PM, Jini George wrote: Thank you very much, David for looking into this. I have incorporated all the comments and the revised

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Thanks Jini, I have no further comments as the tests "passed" for me. David On 25/04/2018 1:26 PM, Jini George wrote: Thank you very much, David for looking into this. I have incorporated all the comments and the revised webrev is at: http://cr.openjdk.java.net/~jgeorge/8174994/webrev.02/inde

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Thank you, Yasumasa. I hope to implement the consolidation with TestSAServer.java (and have the SA core file debug testing template done) as a part of a separate enhancement: https://bugs.openjdk.java.net/browse/JDK-8202297 Let me know if this is not OK with you. Thanks, Jini. On 4/25/2018 6:

Re: PING: RFR: 8199519: Several GC tests fails with: java.lang.NumberFormatException: Unparseable number: "-"

Hi Yasumasa, Your changes look good to me. Thanks, Jini. On 4/25/2018 6:18 PM, Yasumasa Suenaga wrote: PING: Could you review this change? I've sent review request about a month ago, but I do not yet get second reviewer.     > http://cr.openjdk.java.net/~ysuenaga/JDK-8199519/webrev.03/

Re: PING: RFR: 8199519: Several GC tests fails with: java.lang.NumberFormatException: Unparseable number: "-"

PING: Could you review this change? I've sent review request about a month ago, but I do not yet get second reviewer. > http://cr.openjdk.java.net/~ysuenaga/JDK-8199519/webrev.03/ Yasumasa On 2018/04/10 20:10, Yasumasa Suenaga wrote: PING: Could you review it? We need one more reviewe

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Hi Jini, 2018-04-18 15:05 GMT+09:00 Jini George : : I plan to file an enhancement request to address this issue (wrt systemd-coredump) separately since this would apply to other coredump generating test cases also like: test/hotspot/jtreg/compiler/ciReplay/TestSAServer.java. I guessed

Re: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

On 2018-04-25 10:14, Baesken, Matthias wrote: Hi Erik, thanks ! Can I consider this as a review ? In the meantime I created a webrev + bug : webrev for review  : http://cr.openjdk.java.net/~mbaesken/webrevs/8202200/ Looks good to

RE: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

Hi Erik, thanks ! Can I consider this as a review ? In the meantime I created a webrev + bug : webrev for review : http://cr.openjdk.java.net/~mbaesken/webrevs/8202200/ bug : https://bugs.openjdk.java.net/browse/JDK-8202200 Regards, Matthias From: Erik Joelsson [mailto:erik.joels...