RFR: JDK-8193639 - tests failing intermittently with Error attaching to process: Can't create thread_db agent!

Hello, Requesting reviews for ID: https://bugs.openjdk.java.net/browse/JDK-8193639 Webrev: http://cr.openjdk.java.net/~sballal/8193639/webrev.00/ We are seeing intermittent problems with the calls to threaddb in solaris failing. We are not sure of the reason for the failure as it i

Re: [svc] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

Here are the minor updates to the serviceability code based on all the code reviews so far: Incremental webrev: http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.serviceability.v2-incr/ Full webrev: http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.serviceability.v2/ Change

Re: [svc] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

H Serguei, On 22/05/2018 12:19 PM, serguei.spit...@oracle.com wrote: Hi David, I've reviewed the JDI update test coverage. It looks good - great job! Thanks for reviewing it! http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.full.v1/test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNest

Re: RFR(L) : 8199379 : [TESTBUG] Open source vm testbase JDB tests

+1, Misha On 5/18/18, 6:42 PM, serguei.spit...@oracle.com wrote: Hi Igor, This looks good to me. Thank you a lot for taking care about this move from closed to open! Thanks, Serguei On 5/15/18 14:21, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8199379/webrev.00/index.html

Re: [svc] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

Hi David, I've reviewed the JDI update test coverage. It looks good - great job! http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.full.v1/test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java.html Minor: Extra space in the comment before "in Target" and "check that": 316

Re: [svc] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

On 22/05/2018 8:43 AM, mandy chung wrote: On 5/14/18 5:52 PM, David Holmes wrote: This review is being spread across four groups: langtools, core-libs, hotspot and serviceability. This is the specific review thread for serviceability - webrev: http://cr.openjdk.java.net/~dholmes/8010319-JEP18

RE: RFR (S): 8203500: Fix broken links to Specification in "specs" directory

Hi, Mandy. Thanks for the super-fast review! iris From: mandy chung Sent: Monday, May 21, 2018 4:15 PM To: Iris Clark Cc: compiler-...@openjdk.java.net; core-libs-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR (S): 8203500: Fix broken links to Specificatio

RE: RFR (S): 8203500: Fix broken links to Specification in "specs" directory

Hi, Jon. Thanks for the speedy review! iris From: Jonathan Gibbons Sent: Monday, May 21, 2018 4:00 PM To: compiler-...@openjdk.java.net Subject: Re: RFR (S): 8203500: Fix broken links to Specification in "specs" directory Looks good to me. -- Jon On 5/21/18 3:54 PM, Iris Clar

Re: RFR (S): 8203500: Fix broken links to Specification in "specs" directory

The fix looks fine. Mandy On 5/21/18 3:54 PM, Iris Clark wrote: Hi. Please review this small change to fix a few broken links to Specification in the “specs” directory from the JavaDoc API. The incorrect references either not include "{@docRoot}" or include the non-existent "{@docRootParen

RE: RFR (S): 8203500: Fix broken links to Specification in "specs" directory

Hi, Lance. Thanks for the speedy review! iris From: Lance Andersen Sent: Monday, May 21, 2018 3:58 PM To: Iris Clark Cc: compiler-...@openjdk.java.net; core-libs-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR (S): 8203500: Fix broken links to Specification

Re: RFR (S): 8203500: Fix broken links to Specification in "specs" directory

The change looks fine. Iris > On May 21, 2018, at 6:54 PM, Iris Clark wrote: > > Hi. > > > > Please review this small change to fix a few broken links to > > Specification in the "specs" directory from the JavaDoc API. > > The incorrect references either not include "{@docRoot}" or > > inc

RFR (S): 8203500: Fix broken links to Specification in "specs" directory

Hi. Please review this small change to fix a few broken links to Specification in the "specs" directory from the JavaDoc API. The incorrect references either not include "{@docRoot}" or include the non-existent "{@docRootParent}". They should all begin with "{@docRoot}/../specs/". Bug:

Re: [svc] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

On 5/14/18 5:52 PM, David Holmes wrote: This review is being spread across four groups: langtools, core-libs, hotspot and serviceability. This is the specific review thread for serviceability - webrev: http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.serviceability.v1/ Just a pa

Re: [svc] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

Thanks Serguei, I'll update the code. David On 22/05/2018 8:15 AM, serguei.spit...@oracle.com wrote: Hi Coleen and David, On 5/21/18 14:19, David Holmes wrote: Hi Coleen, I've moved your JVM TI comments here to the serviceability RFR thread. On 19/05/2018 8:36 AM, coleen.phillim...@oracle.

Re: [svc] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

Hi Coleen and David, On 5/21/18 14:19, David Holmes wrote: Hi Coleen, I've moved your JVM TI comments here to the serviceability RFR thread. On 19/05/2018 8:36 AM, coleen.phillim...@oracle.com wrote:

Re: [svc] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

Hi Coleen, I've moved your JVM TI comments here to the serviceability RFR thread. On 19/05/2018 8:36 AM, coleen.phillim...@oracle.com wrote: > > http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.full.v1/src/hotspot/share/prims/jvmtiRedefineClasses.cpp.udiff.html > > > There is commen