Hi Sharath,
The changes look fine, but I would request you check this change in as a
subtask of 8193639 and keep 8193639 open.
thanks,
Chris
On 5/21/18 11:02 PM, Sharath Ballal wrote:
Hello,
Requesting reviews for
ID: https://bugs.openjdk.java.net/browse/JDK-8193639
Webrev: http://cr.op
Hi David,
The refactoring in jvmtiRedefineClasses.cpp looks great!
The rest looks good too.
Thanks,
Serguei
On 5/21/18 21:41, David Holmes wrote:
Here are the minor updates to the serviceability code based on all the
code reviews so far:
Incremental webrev:
http://cr.openjdk.java.net/~dhol
Thanks Serguei!
David
On 22/05/2018 6:08 PM, serguei.spit...@oracle.com wrote:
Hi David,
The refactoring in jvmtiRedefineClasses.cpp looks great!
The rest looks good too.
Thanks,
Serguei
On 5/21/18 21:41, David Holmes wrote:
Here are the minor updates to the serviceability code based on all
Thanks Chris. I will check in the change using a subtask.
Thanks,
Sharath
-Original Message-
From: Chris Plummer
Sent: Tuesday, May 22, 2018 12:41 PM
To: Sharath Ballal; serviceability-dev
Subject: Re: RFR: JDK-8193639 - tests failing intermittently with Error
attaching to process: C
On 5/22/18 4:57 AM, David Holmes wrote:
Thanks Serguei!
David
On 22/05/2018 6:08 PM, serguei.spit...@oracle.com wrote:
Hi David,
The refactoring in jvmtiRedefineClasses.cpp looks great!
The rest looks good too.
I agree, thank you for doing the refactoring.
Coleen
Thanks,
Serguei
On 5/
Not sure if this will have an impact, but we have plans to add
parameterization to JFR.start.
It will work like the recording wizard in JMC. All the the widgets you
see in the dialog will be available from command line. For instance, you
will be able to do something like this (syntax and namin
http://cr.openjdk.java.net/~iignatyev//8199383/webrev.00/index.html
> 308253 lines changed: 308253 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources JVMTI tests from VM
testbase?
As usually w/ VM testbase code, these tests are old, they have been run in
hotspot t
Looks like the line "# } nsk/jvmti" is a left over. Otherwise this looks
ok, even if it's an enormous amount of duplication. Hopefully we can
figure out a better way to express common parameters for tests soon.
/Erik
On 2018-05-22 16:35, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iigna
Hi
Could you please review following patch which rewrite vmTestbase/heapdump tests
as a jtreg java tests.
These heapdump tests were developed as a shell tests which verify heapdump
functionality in JDK 5. They work fine but needs some refactoring.
webrev: http://cr.openjdk.java.net/~lmesnik/
