Re: RFR(M): JDK-8203321: Windows: assert(current_query_index < process_query_set->size) failed: invariant

Hi, Maybe this should go on serviceability-dev as well. Thanks, Coleen On 5/22/18 3:24 PM, Markus Gronlund wrote: Greetings, Kindly asking for reviews for the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8203321 Webrev: http://cr.openjdk.java.net/~mgronlun/8203321/webrev00/

Re: RFR 8197387: jcmd started by "root" must be allowed to access all VM processes

Hi, - The incantations for identifying valid accesses occur enough times that it    might be worth introducing a function to do the access check. - With respect to "all processes" keep in mind that in containers like Ddocker, all may not really be all.   Though I'm not sure that is worth a c

Re: jcmd - executing multiple commands at the same safepoint?

Hi Erik, On Tue, May 22, 2018 at 11:08 PM, Erik Gahlin wrote: > Not sure if this will have an impact, but we have plans to add > parameterization to JFR.start. > > It will work like the recording wizard in JMC. All the the widgets you see > in the dialog will be available from command line. For i

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Leonid, My comments inline. On 5/24/2018 12:09 AM, Leonid Mesnik wrote: I am not sure that JMapMetaspaceCore provides any additional coverage. The test just fill 64M of metaspace and then send signal to dump core. So I don't see how this test could improve coverage. I think that idea of or

Re: jcmd - executing multiple commands at the same safepoint?

Hi Thomas, On 05/24/2018 12:08 PM, Thomas Stüfe wrote: Hi Erik, On Tue, May 22, 2018 at 11:08 PM, Erik Gahlin wrote: Not sure if this will have an impact, but we have plans to add parameterization to JFR.start. It will work like the recording wizard in JMC. All the the widgets you see in the

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Found new webrev here: http://cr.openjdk.java.net/~lmesnik/8203491/webrev.01/ and inc diff http://cr.openjdk.java.net/~lmesnik/8203491/webrev.01-00/ I don't know if existing 6

Re: RFR: 81820709 - Container Awareness JEP

On 5/23/18 7:39 AM, Bob Vandette wrote: Should this be an instance method? like cpuacct.getLongValue("cpuacct.usage”); > I did it this way in order to provide a centralized place to check for missing subsystems. The getLongValue method does the checking for all subsystems 137 if

Re: RFR 8197387: jcmd started by "root" must be allowed to access all VM processes

Hi David, In addition to what Thomas said I just wanted to mention that currently jcmd started with elevated privileges ("sudo jcmd") already lists all VM processes running on the host machine and the assumption is that every process in this list could be used by jcmd for further communication

Re: RFR: 81820709 - Container Awareness JEP

> On May 24, 2018, at 2:42 PM, mandy chung wrote: > > > > On 5/23/18 7:39 AM, Bob Vandette wrote: >>> Should this be an instance method? like >>> cpuacct.getLongValue("cpuacct.usage”); > > >> I did it this way in order to provide a centralized place to check >> for missing subsystems. The ge

Re: jcmd - executing multiple commands at the same safepoint?

Hi Frederic, On Thu, May 24, 2018 at 7:29 PM, Frederic Parain wrote: > Hi Thomas, > > > On 05/24/2018 12:08 PM, Thomas Stüfe wrote: >> >> Hi Erik, >> >> On Tue, May 22, 2018 at 11:08 PM, Erik Gahlin >> wrote: >>> >>> Not sure if this will have an impact, but we have plans to add >>> parameteriza

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Leonid, I haven't reviewed your change fully, although I noticed that you merged several tests into one -- TestHeapDumpOnOutOfMemoryError, I don't think it's a good idea as we lose atomicity of test results/executions. could you please split TestHeapDumpOnOutOfMemoryError into independent te

Re: RFR: 81820709 - Container Awareness JEP

On 5/24/18 12:31 PM, Bob Vandette wrote: Yes, I saw that but wasn’t sure how new text that’s added to the launcher.properties file would get localized. Is there a process for getting this done? No action should be needed. Changes to .properties files are tracked and localized version will be

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Thanks for feedback. It is a good idea. Split TestHeapDumpOnOutOfMemoryError into 3 tests. The only test TestHeapDumpOnOutOfMemoryErrorInMetaspace.java requires timeout=240 and excluded from tier1 now. Also I fixed parameters for TestHeapDumpPath test and removed unneeded '@modules java.bas

Re: RFR(XL) : 8199383 : [TESTBUG] Open source VM testbase JVMTI tests

Hi Igor, It looks good to me. Thanks, Serguei On 5/22/18 16:35, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8199383/webrev.00/index.html 308253 lines changed: 308253 ins; 0 del; 0 mod; Hi all, could you please review this patch which open sources JVMTI tests from VM testba

Re: RFR 8197387: jcmd started by "root" must be allowed to access all VM processes

Hi Daniil, All good points. All this (and other) discussion/justification should be captured in the bug report - preferably before the RFR. BTW I did not review the code. Thanks, David On 25/05/2018 4:25 AM, Daniil Titov wrote: Hi David, In addition to what Thomas said I just wanted to men

RFR(S): 8200387: [Graal] fromTonga/nsk/jdi tests hang with Graal as JIT

Hi all, Please, review a fix for:   https://bugs.openjdk.java.net/browse/JDK-8200387 Webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2018/8200387-graal-queue.1/ Summary:   A number of tests are failing when executed wi

Re: RFR 8197387: jcmd started by "root" must be allowed to access all VM processes

Hi Daniil, here is my review: - Like Roger I would prefer to have the uid checks factored out. At least for the hotspot coding, I do not know where to put it in jdk coding. For the hotspot parts, I would add something like: os::Posix::is_root(uid_t uid) ; os::Posix::matches_effective_uid_or_root

RFR(XS): 8203815: add tests failed because of 8203809 to the ProblemList-graal

Hi All, Please, review a fix for the sub-task:   https://bugs.openjdk.java.net/browse/JDK-8203815 of the bug:   https://bugs.openjdk.java.net/browse/JDK-8203809 The patch is: diff -r 55153a374d18 test/hotspot/jtreg/ProblemList-graal.

RFR(XS): 8203816 add tests failed because of 8203174 to the ProblemList-graal

Hi All, Please, review a fix for the sub-task:   https://bugs.openjdk.java.net/browse/JDK-8203816 of the bug:   https://bugs.openjdk.java.net/browse/JDK-8203174 The patch is: diff -r 55153a374d18 test/hotspot/jtreg/ProblemList-graal.txt --- a/test/hotspot/jtreg/ProblemList-graal.txt    Sat May

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

The SA tests look good to me. One minor comment. public static String HEAP_OOME = "heap"; public static String METASPACE_OOME = "metaspace"; These could be declared as public static final String. Thanks, Jini. On 5/25/2018 4:37 AM, Leonid Mesnik wrote: Hi Thanks for feedback. It is

Re: RFR(XS): 8203815: add tests failed because of 8203809 to the ProblemList-graal

That looks fine Serguei. Thanks, David On 25/05/2018 3:57 PM, serguei.spit...@oracle.com wrote: Hi All, Please, review a fix for the sub-task: https://bugs.openjdk.java.net/browse/JDK-8203815 of the bug: https://bugs.openjdk.java.net/browse/JDK-8203809 The patch is: diff -r 55153a374d18 te

Re: RFR(XS): 8203815: add tests failed because of 8203809 to the ProblemList-graal

Thank you, David! Serguei On 5/24/18 23:31, David Holmes wrote: That looks fine Serguei. Thanks, David On 25/05/2018 3:57 PM, serguei.spit...@oracle.com wrote: Hi All, Please, review a fix for the sub-task: https://bugs.openjdk.java.net/browse/JDK-8203815 of the bug: https://bugs.openjdk.j

Re: RFR(XS): 8203816 add tests failed because of 8203174 to the ProblemList-graal

Seems okay Serguei. Thanks, David On 25/05/2018 4:22 PM, serguei.spit...@oracle.com wrote: Hi All, Please, review a fix for the sub-task:   https://bugs.openjdk.java.net/browse/JDK-8203816 of the bug:   https://bugs.openjdk.java.net/browse/JDK-8203174 The patch is: diff -r 55153a374d18 te

Re: RFR(XS): 8203816 add tests failed because of 8203174 to the ProblemList-graal

Thanks, David! Serguei On 5/24/18 23:41, David Holmes wrote: Seems okay Serguei. Thanks, David On 25/05/2018 4:22 PM, serguei.spit...@oracle.com wrote: Hi All, Please, review a fix for the sub-task:    https://bugs.openjdk.java.net/browse/JDK-8203816 of the bug:    https://bugs.openjdk.jav