Hi Daniil,
Looks fine. Small nits:
- please add short comments to os_posix.hpp on the new prototypes. At
least on matches_effective_uid_and_gid_or_root:
e.g. // Returns true if either given uid is effective uid and given
gid is effective gid, or if given uid is root.
- src/hotspot/os/posix/os_po
Hi Rafael,
Thanks for the additional use cases of Unsafe::defineClass and looking
through many different agents to identify their migration path.
Summarize the requirements you collected (please correct/add):
1. need a means to define auxiliary classes in the same runtime package
of an instr
http://cr.openjdk.java.net/~iignatyev//8199371/webrev.00/index.html
> 64675 lines changed: 64675 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources JDWP tests from VM
testbase?
As usually w/ VM testbase code, these tests are old, they have been run in
hotspot test
Looks good to me.
/Erik
On 2018-05-29 14:35, Daniil Titov wrote:
Hi Serguei,
Thank you, for review.
I will need one more reviewer to push this changes.
Best regards,
Daniil
On 5/29/18, 12:01 PM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
It looks good.
T
Hi Serguei,
Thank you, for review.
I will need one more reviewer to push this changes.
Best regards,
Daniil
On 5/29/18, 12:01 PM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
It looks good.
Thanks,
Serguei
On 5/26/18 11:57, Daniil Titov wrote:
Hi Thomas,
Please review a new version of the fix that includes the changes suggested.
Webrev: http://cr.openjdk.java.net/~dtitov/8197387/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8197387
Thank you,
Daniil
On 5/24/18, 10:51 PM, "Thomas Stüfe" wrote:
Hi Daniil,
h
Hei Mandy,
after further investigation I have found several other use cases of
sun.misc.Unsafe::defineClass for which the proposal for JDK-8200559 would
not currently offer a solution. I will try to describe a generic case of
the problem I found:
Java agents sometimes need to communicate state fr
Hi Dan and Chris,
You both already reviewed my version of the fix below.
For your convenience, my webrev was:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.2/
I did not push it into 10 because some number of regressions were
discovered.
Thanks a lot to Alex fo
Hi Thomas,
> On May 26, 2018, at 04:07, Thomas Stüfe wrote:
>
>>
>> I think that it is a fundamental piece of the design. Adding a new diagnostic
>> command to group several commands under a unique safepoint:
>> 1 - requires explicit action from the user (and acknowledgment of the risks)
>>
+1
--alex
On 05/29/2018 12:01, serguei.spit...@oracle.com wrote:
Hi Daniil,
It looks good.
Thanks,
Serguei
On 5/26/18 11:57, Daniil Titov wrote:
Please review the changes that fix a build failure for Jvmti tests.
The fix replaces printf "%ld" format with JLONG_FORMAT macro defined
in the
Hi Daniil,
It looks good.
Thanks,
Serguei
On 5/26/18 11:57, Daniil Titov wrote:
Please review the changes that fix a build failure for Jvmti tests.
The fix replaces printf "%ld" format with JLONG_FORMAT macro defined in the
same way as it is defined in the hotspot
(src/hotspot//share/utili
Hi Gary,
This looks good to me.
But I've added Tim Bell to the mailing list to know his opinion.
Hi Tim,
Could you, please, take a look at this?
What do you thinks about this approach to fix test issues?
Thanks,
Sergue
12 matches
Mail list logo
