On 6/15/18 4:52 PM, Thomas Stüfe wrote:
On Fri, Jun 15, 2018 at 10:36 PM, Chris Plummer
wrote:
On 6/15/18 10:31 AM, Thomas Stüfe wrote:
Coleen, Chris,
thanks for the review. Please find the latest webrev:
Delta:
http://cr.openjdk.java.net/~stuefe/webrevs/8204958-jcmd-cleanups/webrev.01-to
On Fri, Jun 15, 2018 at 10:36 PM, Chris Plummer
wrote:
> On 6/15/18 10:31 AM, Thomas Stüfe wrote:
>>
>> Coleen, Chris,
>>
>> thanks for the review. Please find the latest webrev:
>>
>> Delta:
>> http://cr.openjdk.java.net/~stuefe/webrevs/8204958-jcmd-cleanups/webrev.01-to-02/webrev/index.html
>> F
After some difficulty with the submit cluster, with which Erik helped me out,
the patch passes. It also passed fastdebug hotspot tier 1 testing on my Mac
laptop, which former includes the new test.
I had to increase -Xmx and -Xms to 12m in order to get
TestOldGenCollectionUsage to pass on the s
On 6/15/18 10:31 AM, Thomas Stüfe wrote:
Coleen, Chris,
thanks for the review. Please find the latest webrev:
Delta:
http://cr.openjdk.java.net/~stuefe/webrevs/8204958-jcmd-cleanups/webrev.01-to-02/webrev/index.html
Full:
http://cr.openjdk.java.net/~stuefe/webrevs/8204958-jcmd-cleanups/web
Hi Frederic,
this is nice and now I am surprised how small the change is :)
I played around with it a bit, combining VM.metaspace, VM.classloaders
and VM.systemdictionary, including options. All worked well.
VM.stringtable did not produce output and VM.info, as you predicted,
crashes the VM becau
Coleen, Chris,
thanks for the review. Please find the latest webrev:
Delta:
http://cr.openjdk.java.net/~stuefe/webrevs/8204958-jcmd-cleanups/webrev.01-to-02/webrev/index.html
Full:
http://cr.openjdk.java.net/~stuefe/webrevs/8204958-jcmd-cleanups/webrev.02/webrev/
I changed the copyright dat
Hi,
Here’s a first prototype to explore running multiple commands in a single
safepoint:
http://cr.openjdk.java.net/~fparain/DCmdRunAtSafepoint/webrev.00/
The syntax is very simple, with the character ‘+’ used as the delimiter between
commands.
$ ./build/macosx-x64-debug/images/jdk/bin/jcmd 2
On 6/15/18 1:04 AM, Chris Plummer wrote:
Hi Thomas,
I'm not certain why you added default field initializers for
CmdLine::CmdLine when each field is explicitly initialized within the
method body.
I think the C++ optimizer would elide any unnecessary initializations
and it seems safe in ca
Thank you, Erik H., Erik D. and Volker for the review!
I've pushed the patch.
Thanks,
Serguei
On 6/15/18 02:30, Erik Helin wrote:
On 06/15/2018 11:16 AM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8205096
Webrev:
http://cr.openjdk.jav
On 06/15/2018 11:16 AM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8205096
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2018/8205096-missed-files-for-8203394/
Looks good, Reviewed. I can confirm that jdk/jdk builds with patch
a
Thank you, Robbin!
Serguei
On 6/15/18 02:27, Robbin Ehn wrote:
On 06/15/2018 11:23 AM, David Holmes wrote:
Ship it!
+1
/Robbin
Thanks,
David
On 15/06/2018 7:16 PM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8205096
Webrev:
http:
Can't comment on the content, but at least it fixes the build so
thumbs up from me!
Regards,
Volker
On Fri, Jun 15, 2018 at 11:16 AM, serguei.spit...@oracle.com
wrote:
> Please, review a fix for:
> https://bugs.openjdk.java.net/browse/JDK-8205096
>
> Webrev:
>
> http://cr.openjdk.java.net/~ss
On 06/15/2018 11:23 AM, David Holmes wrote:
Ship it!
+1
/Robbin
Thanks,
David
On 15/06/2018 7:16 PM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8205096
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2018/8205096-missed-files
Thanks a lot, Thomas!
Serguei
On 6/15/18 02:26, Thomas Schatzl wrote:
Hi,
On Fri, 2018-06-15 at 19:23 +1000, David Holmes wrote:
Ship it!
+1
Thomas
Hi,
On Fri, 2018-06-15 at 19:23 +1000, David Holmes wrote:
> Ship it!
+1
Thomas
Thanks, David!
Serguei
On 6/15/18 02:23, David Holmes wrote:
Ship it!
Thanks,
David
On 15/06/2018 7:16 PM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8205096
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2018/8205096-missed-fil
Ship it!
Thanks,
David
On 15/06/2018 7:16 PM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8205096
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2018/8205096-missed-files-for-8203394/
Summary:
I forgot to "hg add" all new file
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8205096
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2018/8205096-missed-files-for-8203394/
Summary:
I forgot to "hg add" all new files when committed fixes
18 matches
Mail list logo
