On 6/19/18 23:29, Jeremy Manson wrote:
Maybe we should make that clarification.
Also, the reason I danced around that in my revision is
that
Understand that.
But it is not a good style to clarify about Sa
On 6/19/18 21:54, David Holmes wrote:
On 20/06/2018 2:41 PM, serguei.spit...@oracle.com wrote:
On 6/19/18 21:11, Jeremy Manson wrote:
That would be okay with me, assuming that my other corrections are
made.
Another option would be to say "non-sampling" instead of
"unconditional":
== Sent w
On 20/06/2018 2:41 PM, serguei.spit...@oracle.com wrote:
On 6/19/18 21:11, Jeremy Manson wrote:
That would be okay with me, assuming that my other corrections are made.
Another option would be to say "non-sampling" instead of "unconditional":
== Sent when a method causes the virtual machine t
On 6/19/18 21:11, Jeremy Manson wrote:
That would be okay with me, assuming that my other
corrections are made.
Another option would be to say "non-sampling" instead of
"unconditional":
== Sent when a method causes the vir
That would be okay with me, assuming that my other corrections are made.
I'd also like to fix the spelling of instrumentation in the first sentence.
Jeremy
On Mon, Jun 18, 2018 at 11:01 PM serguei.spit...@oracle.com <
serguei.spit...@oracle.com> wrote:
> Hi Jeremy and David,
>
> Sorry for being
Thanks!
On 6/19/18 5:38 PM, serguei.spit...@oracle.com wrote:
Looks fine.
Thanks,
Serguei
On 6/19/18 15:23, Chris Plummer wrote:
Hi,
Please review the following change to problem list a test. I plan to
push under the trivial change rules. I tested by running the
:vmTestbase_nsk_jvmti test
Looks fine.
Thanks,
Serguei
On 6/19/18 15:23, Chris Plummer wrote:
Hi,
Please review the following change to problem list a test. I plan to
push under the trivial change rules. I tested by running the
:vmTestbase_nsk_jvmti test group and verifying that the test was not run.
https://bugs.o
+1
Thanks,
Serguei
On 6/19/18 16:53, Chris Plummer wrote:
Hi Gary,
The sp05t003 changes look fine. Serquei's question about
hs203t003 leads me to ask what happens if the redefine never
happens,
Hi Gary,
The sp05t003 changes look fine. Serquei's question about hs203t003
leads me to ask what happens if the redefine never happens,
possibly due to some error. Seems we are destined for a timeout
then (not sure how long that will take), whereas the curr
Hi,
Please review the following change to problem list a test. I plan to
push under the trivial change rules. I tested by running the
:vmTestbase_nsk_jvmti test group and verifying that the test was not run.
https://bugs.openjdk.java.net/browse/JDK-8205149
diff --git a/test/hotspot/jtreg/Pro
Hi Gary,
The fix looks good in general.
One comment though:
http://cr.openjdk.java.net/~gadams/6545967/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS203/hs203t003/hs203t003.java.frames.html
80 public boolean age
There are some rare race conditions that impact some jvmti tests that
suspend and resume threads. These tests were recently moved into
the open repos.
Webrev: http://cr.openjdk.java.net/~gadams/6545967/webrev.00/
The fix in hs203t003 replaces a blind 10 second sleep, with a specific
check to w
Hi Alan, Robbin,
On Tue, Jun 19, 2018 at 1:53 PM, Robbin Ehn wrote:
> Hi,
>
> On 06/18/2018 05:56 PM, Alan Bateman wrote:
>>
>> On 16/06/2018 18:23, Thomas Stüfe wrote:
>>>
>>> :
>>>
>>>
>>> Is that by design?
>>>
>> It's pluggable. The two built-in vmid formats are the pid and pid@host for
>> lo
Hi,
On 06/18/2018 05:56 PM, Alan Bateman wrote:
On 16/06/2018 18:23, Thomas Stüfe wrote:
:
Is that by design?
It's pluggable. The two built-in vmid formats are the pid and pid@host for local
and remote respectively. I don't recall any discussion here about identifying an
application by nam
Hi all,
Thanks Chris and Christoph for the reviews! Christoph, I'll incorporate the
little improvement you suggested.
David, are you OK with the change as well?
Thanks again,
Gunter
On 12.06.18, 01:13, "Chris Plummer" wrote:
Hi Gunter,
The changes look fine. I can live with the
Hi Thomas,
thanks for your review!
I think the upper example output stems from some older
jstatd. Probably the output got two new values added.
I don't feel like making up values, so I'd rather remove the
old output. Is that fine with you?
Best regards,
Goetz.
> -Original Message-
16 matches
Mail list logo
