Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8205561
diff --git a/test/hotspot/jtreg/ProblemList.txt
b/test/hotspot/jtreg/ProblemList.txt
--- a/test/hotspot/jtreg/ProblemList.txt
+++ b/test/hotspot/jtreg/ProblemList.txt
@@ -166,7 +166,7 @@
vmTestbase/vm/mlvm/
Hi Daniil,
Thank you for stabilizing these tests.
I don't think your comment changes for the following are correct:
120 // instances created in this way aren't reachable for
the purposes of garbage collection,
121 // to make it reachable call enableCollection() for
t
Hi Daniil,
It looks good - great analysis.
Thank you for taking care about these failures!
I guess, the tests could fail not only with the Graal.
Hopefully, they became more stable now.
Thanks,
Serguei
On 6/22/18 19:13, Daniil Titov wrote:
Please review the changes that fix 15 tests failures
Please review the changes that fix 15 tests failures when running with Graal.
The main problem here is that the tests assume that no garbage collection
happens before the tests complete their checks. The other problem is that the
tests could not strictly distinguish the objects created by the de
Hello Jini,
In general this looks pretty good, but it's also breaking some new
ground as it's adding generation of native source in the java gensrc
step. Mixing native code with the java code that the genrcs targets and
gensrc output directories are meant for seems ok for now, but may cause
t
Hi Thomas,
It looks good to me.
A couple of minor comments below.
http://cr.openjdk.java.net/~stuefe/webrevs/8205531-vm.classloader-tree-folding/webrev.00/webrev/src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp.frames.html
135 // we we ad
Summary: Modify SA code to not use SymbolTable and remove it.
This is to support the concurrent hashtable for SymbolTable.
open webrev at http://cr.openjdk.java.net/~coleenp/8205534.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8205534
Tested with hs-tier1-5.
Thanks,
Coleen
Resent with the correct subject, sorry.
..Thomas
On Fri, Jun 22, 2018 at 9:08 PM, Thomas Stüfe wrote:
> Hi all,
>
> may I have reviews for this small enhancement to the jcmd
> VM.classloader diagnostic command:
>
> https://bugs.openjdk.java.net/browse/JDK-8205531
> http://cr.openjdk.java.net/~st
Hi all,
may I have reviews for this small enhancement to the jcmd
VM.classloader diagnostic command:
https://bugs.openjdk.java.net/browse/JDK-8205531
http://cr.openjdk.java.net/~stuefe/webrevs/8205531-vm.classloader-tree-folding/webrev.00/webrev/
VM.classloaders prints a tree of class loaders.
Hi all,
[Including build-dev also since this includes build related changes].
Requesting reviews for:
https://bugs.openjdk.java.net/browse/JDK-8189429 (SA: MacOSX: Replace
the deprecated PT_ATTACH with PT_ATTACHEXC)
Webrev: http://cr.openjdk.java.net/~jgeorge/8189429/webrev.04/
This is the
Hi Jeremy,
Okay, let me look at it once more before making final decision.
We have all suggestions and preferences listed.
Thanks,
Serguei
On 6/22/18 08:22, Jeremy Manson wrote:
Hey folks -
On 22/06/2018 4:08 PM, Lindenmaier, Goetz wrote:
Hi David,
Obviously using "@run othervm " you can invalidate what may have
been checked in a @require.
As I understand with othervm you can not switch the user, or even start the
other vm on a different system.
No of course not, this all happe
Hi,
Ok, so I now added
vm.hasSA and
vm.hasSAandCanAttach
I use the first in the JMapCore tests, and in the tests that don't check
shouldSAAttach()
right at the beginning.
Wherever the test is immediately ended after checking shouldSAAttach(), I
removed shouldSAAttach(), and added vm.hasSAan
13 matches
Mail list logo
