On 7/9/18 19:35, David Holmes wrote:
On 10/07/2018 12:07 PM, serguei.spit...@oracle.com wrote:
Hi David,
It looks good modulo the minor comments that others have already found.
Thanks for taking a look.
Could I ask you to fix a couple of really minor issues in new test?
Unneeded spaces are
On 10/07/2018 12:07 PM, serguei.spit...@oracle.com wrote:
Hi David,
It looks good modulo the minor comments that others have already found.
Thanks for taking a look.
Could I ask you to fix a couple of really minor issues in new test?
Unneeded spaces are at lines 84 and 51 in .java and .c fi
Hi David,
It looks good modulo the minor comments that others have already found.
Could I ask you to fix a couple of really minor issues in new test?
Unneeded spaces are at lines 84 and 51 in .java and .c files:
83 if (mbean.isThreadCpuTimeSupported() &&
84 mbean.isThrea
Thanks for looking at this Coleen.
David
On 10/07/2018 10:11 AM, coleen.phillim...@oracle.com wrote:
This looks good! Thank you for fixing these failures.
Coleen
On 7/9/18 7:22 PM, David Holmes wrote:
Adding back runtime
On 10/07/2018 8:45 AM, Alex Menkov wrote:
+1
Thanks for looking at
Adding back runtime
On 10/07/2018 8:45 AM, Alex Menkov wrote:
+1
Thanks for looking at this Alex!
couple minor notes (no need to resend review)
Webrev updated in place (v3) for others to see.
src/hotspot/os/linux/os_linux.cpp
please replace
5581 }
5582 else {
with
} else {
+1
couple minor notes (no need to resend review)
src/hotspot/os/linux/os_linux.cpp
please replace
5581 }
5582 else {
with
} else {
test/hotspot/jtreg/runtime/jni/terminatedThread/libterminatedThread.c
please fix error reporting (I suppose you mean "TEST ERROR:
pthread_create fai
Thanks Chris!
Can I please get a second review.
David
On 10/07/2018 7:50 AM, Chris Plummer wrote:
On 7/9/18 2:41 PM, David Holmes wrote:
Hi Chris,
On 10/07/2018 4:22 AM, Chris Plummer wrote:
Hi David,
Would it be better to problem list this test on solaris using
JDK-8156708. That way when
On 7/9/18 2:41 PM, David Holmes wrote:
Hi Chris,
On 10/07/2018 4:22 AM, Chris Plummer wrote:
Hi David,
Would it be better to problem list this test on solaris using
JDK-8156708. That way when JDK-8156708 is fixed it can come off the
problem list and start executing on solaris.
JDK-8156708
Hi Chris,
On 10/07/2018 4:22 AM, Chris Plummer wrote:
Hi David,
Would it be better to problem list this test on solaris using
JDK-8156708. That way when JDK-8156708 is fixed it can come off the
problem list and start executing on solaris.
JDK-8156708 is already fixed - it's a dup of JDK-815
Requesting reviews for enabling SA tests on OS X for Mach5.
https://bugs.openjdk.java.net/browse/JDK-8199700
Webrev: http://cr.openjdk.java.net/~jgeorge/8199700/webrev.00/
The changes are mostly to include the addition of sudo privileges to the
SA launchers for OSX if Platform.shouldSAAttach()
Hi David,
Would it be better to problem list this test on solaris using
JDK-8156708. That way when JDK-8156708 is fixed it can come off the
problem list and start executing on solaris.
thanks,
Chris
On 7/8/18 4:58 PM, David Holmes wrote:
tl;dr skip the new regression test on Solaris
New w
Hi Chris,
thanks for the review.
> What testing have you done?
I've tested the change by debugging by hand in eclipse and jdb, running the
com/sun/jdi rtreg tests and the jdwp jck tests. And analog code is running in
the SAP JVM for many years.
> How long does this test take to run.
15 s ac
12 matches
Mail list logo
