Re: RFR: 8209585: [Graal] vmTestbase/nsk/jvmti/scenarios/sampling tests fail with "Too small stack of resumed thread"

2018-08-26 Thread serguei.spit...@oracle.com
Hi Jc, Initially, I has the same concern. But now I think there is no point to take these values on non-suspended threads. It has to be good enough to compare the values taken on suspended threads only. Thanks, Serguei

Re: RFR: 8209585: [Graal] vmTestbase/nsk/jvmti/scenarios/sampling tests fail with "Too small stack of resumed thread"

2018-08-26 Thread serguei.spit...@oracle.com
Hi Daniil, I agree with your approach to fix this issue. There is no point to compare the values of frameStackSize and frameCount taken on non-suspended threads. It is just a source of failures. Reviewed. Thanks,

Re: RFR: (S): JDK-8204308 : SA: serviceability/sa/TestInstanceKlassSize*.java fails when running in CDS mode

2018-08-26 Thread Jini George
Thank you very much, Coleen and Lois, for the reviews. I problem listed the new test on Solaris since any SA test is likely to fail intermittently on Solaris now due to JDK-8193639 (https://bugs.openjdk.java.net/browse/JDK-8193639). (All SA tests are quarantined on Solaris now). Thanks, Jini.