RE: OOM counters

* For reference, we added an OOM callback to then do whatever reporting we want to in that case in native; * this allows us to be very careful of not trying to allocate things during an OOM. * HI JC, what callbacks are you referring to exactly ? Best regards, Matthias From: JC B

Re: RFR 8163083: SocketListeningConnector does not allow invocations with port 0

Looks good to me. For the javadoc 72 * 73 * If arguments contains addressing information. and 74 * only one connection will be accepted, the {@link #accept accept} method 75 * can be called immediately without calling this method. 76 * 77 * If the addressing

Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core

Hi Fairoz, This looks good to me. One nit which got missed out in the original change also is that in saproc.cpp, the following comments 452 453 // Pstack_iter() proc_stack_f callback prior to Nevada-B159 476 // Pstack_iter() proc_stack_f callback in Nevada-B159 or later 477 /*ARGSUSED*/

Re: RFR: JDK-8208471: nsk/jdb/unwatch/unwatch002/unwatch002.java fails with "Prompt is not received during 300200 milliseconds"

Patch attached. On 9/20/18, 8:17 PM, Chris Plummer wrote: Ok, so you're just suggesting that findPrompt() should require that the prompt be at the end of the line. In fact probably on a line by itself. Keep in mind that we also have issues with async printing that tends to result in the promp

RE: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core

Hi Jini, Thanks for the review. Thanks, Fairoz > -Original Message- > From: Jini George > Sent: Friday, September 21, 2018 4:07 PM > To: Fairoz Matte ; serviceability- > d...@openjdk.java.net > Subject: Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 > when loading du

RE: OOM counters

> > Sorry, when I said "we added" I meant "in our internal JDK at Google" :-); > not the OpenJDK one. But basically, from what I can tell when I look at the > code; when an OOM happens, > we get a callback and do some book-keeping in native land before returning > and letting the JVM close up sh

Re: RFR 8163083: SocketListeningConnector does not allow invocations with port 0

Thank you, JC! Please review an updated version of the patch that addresses these issues. Bug: https://bugs.openjdk.java.net/browse/JDK-8163083 Webrev: http://cr.openjdk.java.net/~dtitov/8163083/webrev.03/ Best regards, Daniiil From: JC Beyler Date: Thursday, September 20, 2018 at 8:59 PM To

Re: RFR: JDK-8208471: nsk/jdb/unwatch/unwatch002/unwatch002.java fails with "Prompt is not received during 300200 milliseconds"

I don't think Alex actually gave a thumbs up for this change yet. He just offered a suggestion for an alternate way to fix. Chris On 9/21/18 5:18 AM, Gary Adams wrote: Patch attached. On 9/20/18, 8:17 PM, Chris Plummer wrote: Ok, so you're just suggesting that findPrompt() should require tha

Re: RFR (M) 8210689: Remove the multi-line old C style for string literals

Hi JC, I didn't realize you intended to move all the strings into a "const char*" first. Seems unnecessary, and I think not as easy to read:  138 const char* debug_str =  139 "TEST FAILED: JVMTI_EVENT_CLASS_LOAD

Re: RFR (M) 8210689: Remove the multi-line old C style for string literals

On 9/21/18 10:55 AM, JC Beyler wrote: Hi Chris, I hesitated to be honest and then thought that debug_str was better as you would clearly see that it is a multi-lilne string and what parameters are what. But I'll take yo

RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests

Hi, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8210987 http://cr.openjdk.java.net/~cjplummer/8210987/webrev.00/ Here's an example of some "before" output on windows: Sending command: cont reply[0]: > reply[1]: Method entered: "thread=MyThread-1", java.util.Locale.g

Re: RFR (M) 8210689: Remove the multi-line old C style for string literals

Hi JC, Overall looks good. Just a couple minor edits needed: In nativemethbind003.cpp:  158 NSK_DISPLAY1("Inside the registerNative()\nFinding class \"%s\" ...\n", CLASS_SIG); This was two lines and you made it one with a \n i

Re: RFR (M) 8210689: Remove the multi-line old C style for string literals

Hi Chris, Done here: Webrev: http://cr.openjdk.java.net/~jcbeyler/8210689/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8210689 Anything else? and anybody else motivated to look? Thanks again! Jc On Fri, Sep 21, 2018 at 2:07 PM Chris Plummer wrote: > Hi JC, > > Overall looks good.

Re: RFR: JDK-8208471: nsk/jdb/unwatch/unwatch002/unwatch002.java fails with "Prompt is not received during 300200 milliseconds"

Thanks, Chris, Looked at the issues and nsk jdb stuff again - may be you are right and fixing nsk jdb code we can get a bunch of new test issues. So ok, lets make local fixes for the known issues for now. LGTM. --alex On 09/21/2018 09:12, Chris Plummer wrote: I don't think Alex actually gave

Re: RFR: JDK-8208473: [TESTBUG] nsk/jdb/exclude/exclude001/exclude001.java is timing out on solaris-sparc again

+1 --alex On 09/20/2018 14:47, Chris Plummer wrote: Looks good. Still not bullet proof, but I'm not sure it's possible to write tests like this in a way that will work no matter what output is produced by the method enter/exit events. Chris On 9/20/18 10:59 AM, Gary Adams wrote: The test f

Re: RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests

Looks fine. Thanks, David On 21/09/2018 4:46 PM, Chris Plummer wrote: Hi, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8210987 http://cr.openjdk.java.net/~cjplummer/8210987/webrev.00/ Here's an example of some "before" output on windows: Sending command: cont repl

Re: RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests

Thanks David and JC! On 9/21/18 2:57 PM, David Holmes wrote: Looks fine. Thanks, David On 21/09/2018 4:46 PM, Chris Plummer wrote: Hi, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8210987 http://cr.openjdk.java.net/~cjplummer/8210987/webrev.00/ Here's an example of

Re: RFR (M) 8210689: Remove the multi-line old C style for string literals

Hi Jc, overall looks good (no changes in the logging) except test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t003/hs201t003.cpp : -if ((strcmp(name, expMeth) == 0) && -(strcmp(sig, expSig) == 0)) { -NSK_DISPLAY4("= %s event received for the teste

Re: RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests

+1 --alex On 09/21/2018 14:19, JC Beyler wrote: Hi Chris, Looks good to me! Thanks, Jc On Fri, Sep 21, 2018 at 1:47 PM Chris Plummer > wrote: Hi, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8210987 http://cr.openj

Re: RFR 8163083: SocketListeningConnector does not allow invocations with port 0

One more note: please add "@Override" annotation to the SocketListeningConnector.updateArgumentMapIfRequired --alex On 09/21/2018 02:26, gary.ad...@oracle.com wrote: Looks good to me. For the javadoc 72 * 73 * If arguments contains addressing information. and 74 * onl

Re: RFR (M) 8210689: Remove the multi-line old C style for string literals

LGTM. --alex On 09/21/2018 17:06, JC Beyler wrote: Hi Alex, Good catch, it was not done on purpose but now fixed: Webrev: http://cr.openjdk.java.net/~jcbeyler/8210689/webrev.03/ Bug: https://bugs.openjdk.java.net/browse/JDK-8210689