RE: RFR (XS) JDK-8207745: serviceability/sa/TestJmapCore.java times out parsing a 4GB hprof file

Thanks for the review Jini. Thanks, Sharath -Original Message- From: Jini George Sent: Wednesday, September 26, 2018 9:42 AM To: Sharath Ballal; serviceability-dev Subject: Re: RFR (XS) JDK-8207745: serviceability/sa/TestJmapCore.java times out parsing a 4GB hprof file Looks good to

Re: RFR (XS) JDK-8207745: serviceability/sa/TestJmapCore.java times out parsing a 4GB hprof file

Looks good to me. Thanks, Jini. On 9/24/2018 9:19 AM, Sharath Ballal wrote: Hi, Pls review this test fix to add "-Xmx512m" to SA tests which create either core file or heap dump, to avoid timeout due to large heap sizes. Bug id: https://bugs.openjdk.java.net/browse/JDK-8207745 Webrev: http

Re: RFR 8163083: SocketListeningConnector does not allow invocations with port 0

Looks good. --alex On 09/25/2018 10:32, Daniil Titov wrote: HI JC, The webrev is updated to address this. Webrev: http://cr.openjdk.java.net/~dtitov/8163083/webrev.06 Bug: https://bugs.openjdk.java.net/browse/JDK-8163083 Thanks! --D

Re: RFR (M) 8211036 : Remove the NSK_STUB macros from vmTestbase for non jvmti

+1 --alex On 09/24/2018 11:40, Igor Ignatyev wrote: (cc-ing hotspot-dev alias) Hi Jc, the fix looks good to me. don't forget to clean up nsk/share/jni/README at the end. Thanks, -- Igor On Sep 24, 2018, at 9:28 AM, JC Beyler wrote: Hi all, As the tests have become C++ tests, the NSK_CP

Re: RFR 8163083: SocketListeningConnector does not allow invocations with port 0

HI JC, The webrev is updated to address this. Webrev: http://cr.openjdk.java.net/~dtitov/8163083/webrev.06 Bug: https://bugs.openjdk.java.net/browse/JDK-8163083 Thanks! --Daniil From: JC Beyler Date: Monday, September 24, 2018 at 8:47 PM To: Cc: , , Subject: Re: RFR 8163083: S

Re: RFR: 8208686: [AOT] JVMTI ResourceExhausted event repeated for same allocation

Adding serviceability-dev@... since this is JVM/TI... Dan On 9/25/18 10:48 AM, Doug Simon wrote: A major design point of Graal is to treat allocations as non-side effecting to give more freedom to the optimizer by reducing the number of distinct FrameStates that need to be managed. When fail

Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core

Hi Fairoz, I took a better look at the changes and I realized that the cleanup related to SOLARIS_11_B159_OR_LATER would be valid for only JDK9 and later. Since JDK8 is supported for Solaris 10 too, I believe that the cleanup related changes done as a part of JDK-8164383 should not be done fo