Hi Sven,
I created https://bugs.openjdk.java.net/browse/JDK-8212795 to track this
issue. NB is using the internal API that is unused in JDK and hence no
test uncovers this regression.
I have a patch that passes a map of key to values to
CompositeDataSupport rather than passing two synchron
On 10/22/18 10:25 AM, Lois Foltan wrote:
On 10/22/2018 1:49 AM, Ioi Lam wrote:
Hi David,
Thanks for the review. Updated webrev:
http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04/
http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-cla
Hi Ioi,
Sorry for all the extra work in the test. ;-)
The updates look good to me (and I've seen follow up comments).
Thanks,
David
On 22/10/2018 3:49 PM, Ioi Lam wrote:
Hi David,
Thanks for the review. Updated webrev:
http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-
Okay, thanks!
Serguei
On 10/22/18 18:49, Ioi Lam wrote:
Hi Serguei,
Thanks for the review!
On 10/22/18 5:09 PM, serguei.spit...@oracle.com wrote:
Hi Ioi,
It looks good to me.
Hi Serguei,
Thanks for the review!
On 10/22/18 5:09 PM, serguei.spit...@oracle.com wrote:
Hi Ioi,
It looks good to me.
Some minor questions below.
http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04/src/hotspot/share/classfile/systemDictionary.hpp.frames.html
Sounds good. Thanks for trying that.
Thanks,
Jiangli
> On Oct 22, 2018, at 6:43 PM, Ioi Lam wrote:
>
>
>
>> On 10/22/18 3:06 PM, Jiangli Zhou wrote:
>>> On 10/22/18 10:56 AM, Ioi Lam wrote:
>>>
>>>
>>>
On 10/22/18 10:25 AM, Jiangli Zhou wrote:
Hi Ioi,
Looks good. Plea
On 10/22/18 3:06 PM, Jiangli Zhou wrote:
On 10/22/18 10:56 AM, Ioi Lam wrote:
On 10/22/18 10:25 AM, Jiangli Zhou wrote:
Hi Ioi,
Looks good. Please see comments below.
- src/hotspot/share/classfile/javaClasses.cpp
4254 assert(JvmtiEnvBase::get_phase() <= JVMTI_PHASE_PRIMORDIAL,
4255
I'm fine with it
--alex
On 10/22/2018 17:26, Daniil Titov wrote:
Thank you, Chris for reviewing this change!
Alex, JC, Garry could you please say are you OK with this version of the webrev?
Webrev: http://cr.openjdk.java.net/~dtitov/8211736/webrev.05/
Issue: https://bugs.openjdk.java.net/brow
Ok by me
Sent from my iPad
> On Oct 22, 2018, at 8:26 PM, Daniil Titov wrote:
>
> Thank you, Chris for reviewing this change!
>
> Alex, JC, Garry could you please say are you OK with this version of the
> webrev?
>
> Webrev: http://cr.openjdk.java.net/~dtitov/8211736/webrev.05/
> Issue: htt
Thank you, Chris for reviewing this change!
Alex, JC, Garry could you please say are you OK with this version of the webrev?
Webrev: http://cr.openjdk.java.net/~dtitov/8211736/webrev.05/
Issue: https://bugs.openjdk.java.net/browse/JDK-8211736
Best regards,
Daniil
On 10/22/18, 11:18 AM, "Chris
Hi Jc,
new webrev:
http://cr.openjdk.java.net/~amenkov/exclusiveBind/webrev.02/
--alex
On 10/20/2018 20:29, JC Beyler wrote:
Hi Alex,
It looks really good to me now. The test and JdbTest are now easier to
read because we do not have the noise of the debuggee trying to attach.
A few nits:
Lgtm.
There’s a similar issue with ‘{‘’}’ you might want to fix separately, except in
the opposite direction :), e.g., in
test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/MethodBind/JvmtiTest/JvmtiTest.cpp,
+#define JVMTI_ERROR_CHECK(str,res) if (res != JVMTI_ERROR_NONE) { printf(str);
printf("%d\n"
Hi Ioi,
It looks good to me.
Some minor questions below.
http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04/src/hotspot/share/classfile/systemDictionary.hpp.frames.html
706 // Resolve well_known classes so they ca
Sorry Dean I'm concerned about a thread termination bottleneck with
this. A simple microbenchmark that creates 500,000 threads that have to
run and terminate, shows a 15+% slowdown on my Linux box. I tried to
find some kind of real benchmarks that covers thread termination but
couldn't see anyt
On 10/22/18 10:56 AM, Ioi Lam wrote:
On 10/22/18 10:25 AM, Jiangli Zhou wrote:
Hi Ioi,
Looks good. Please see comments below.
- src/hotspot/share/classfile/javaClasses.cpp
4254 assert(JvmtiEnvBase::get_phase() <= JVMTI_PHASE_PRIMORDIAL,
4255 "Field offsets of well-known clas
Hi Jc,
It looks good.
Thanks!
Serguei
On 10/22/18 11:30, JC Beyler wrote:
Hi all,
Here is the last webrev (3 out of 3) to remove
the spaces after/before () from vmTestbase. It
Hi Gary,
As I see currently multiple tests already use the patterns that in fact are
localized messages, e.g. for 'Breakpoint hit' the following tests expect to
find this message in the JDB output.
grep -rn 'Breakpoint hit' open/test/jdk/com/sun/jdi/
open/test/jdk/com/sun/jdi//JdbMissStep.java
LGTM
Thanks,
Serguei
On 10/22/18 14:38, Alex Menkov wrote:
Hi Jc, Gary, Serguei,
Just for the record, updated webrev:
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev.01
(spaces are added, "steps" in the comment is replaced with "stops")
--alex
On 10/22/2018 13:10, sergue
Hi Jc, Gary, Serguei,
Just for the record, updated webrev:
http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev.01
(spaces are added, "steps" in the comment is replaced with "stops")
--alex
On 10/22/2018 13:10, serguei.spit...@oracle.com wrote:
Hi Alex,
The fix looks good.
+1 f
Hi Alex,
It looks good.
Thanks!
Serguei
On 10/22/18 12:56, JC Beyler wrote:
Hi Alex,
Done, I left this one:
Hi Alex,
LGTM.
Thanks,
Serguei
On 10/19/18 15:56, Alex Menkov wrote:
Hi Jc,
Updated fix:
http://cr.openjdk.java.net/~amenkov/exclusiveBind/webrev.01/
Moved shared code to new Debuggee class.
--alex
On 10/19/2018 10:34, JC Beyler wrote:
Hi Alex,
I remember seeing this same code so went lo
LGTM.
--alex
On 10/22/2018 11:29, JC Beyler wrote:
Hi all,
Here is the next webrev (second out of 3) to remove the spaces
after/before () from vmTestbase. It is straightforward and I generated
the webrev with white-space changes showing up of course:
Webrev: http://cr.openjdk.java.net/~jcb
Hi Alex,
The fix looks good.
+1 for the Jc's suggestion to add spacing to the line:
176 for (int i=0; i<50; i++) {
Thanks,
Serguei
On 10/18/18 15:42, Alex Menkov wrote:
Hi all,
Please review small test fix for
https://bugs.openjdk.java.net/browse/JDK-8212665
webrev:
http://cr.openj
This line was not changed in webrev.01 :)
Anyway looks good.
--alex
On 10/22/2018 12:56, JC Beyler wrote:
Hi Alex,
Done, I left this one:
- if (!NSK_JVMTI_VERIFY(
- jvmti->IterateOverHeap(JVMTI_HEAP_OBJECT_EITHER,
heapObjectCallback, (void *)user_data))) {
+
Hi Jc,
Looks good to me.
Could you please update
nsk/jvmti/IterateOverHeap/iterheap007/iterheap007.cpp :
if (!NSK_JVMTI_VERIFY(
-)) {
+)) {
=>
if (!NSK_JVMTI_VERIFY()) {
As all s there are quite short.
--alex
On 10/19/2018 14:56, JC Beyler wrote:
Hi Chris,
Hi Daniil,
Looks good.
thanks,
Chris
On 10/19/18 4:01 PM, Daniil Titov wrote:
Hi Chris,
Please review an updated version of the fix that makes the tests to use a
custom pattern while waiting for the command to complete.
Webrev: http://cr.openjdk.java.net/~dtitov/8211736/webrev.05/
Issue: h
On 10/21/18 6:15 PM, Ioi Lam wrote:
Re-sending to the correct mailing lists. Please disregard the other
email.
http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v03/
https://bugs.openjdk.java.net/browse/JDK-8212200
Hi,
CDS has various built-in assumptions tha
On 10/22/18 10:25 AM, Jiangli Zhou wrote:
Hi Ioi,
Looks good. Please see comments below.
- src/hotspot/share/classfile/javaClasses.cpp
4254 assert(JvmtiEnvBase::get_phase() <= JVMTI_PHASE_PRIMORDIAL,
4255 "Field offsets of well-known classes must be computed
in JVMTI_PHASE_P
On 10/22/2018 1:49 AM, Ioi Lam wrote:
Hi David,
Thanks for the review. Updated webrev:
http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04/
http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04.delta/
Hi Ioi,
Looks good. A c
Hi Ioi,
Looks good. Please see comments below.
- src/hotspot/share/classfile/javaClasses.cpp
4254 assert(JvmtiEnvBase::get_phase() <= JVMTI_PHASE_PRIMORDIAL,
4255 "Field offsets of well-known classes must be computed in
JVMTI_PHASE_PRIMORDIAL or before");
Maybe it is worth add
I assume it's a simple ThreadInfo then a simple text form would work; if
not, you can use the format NB use if you have the reader.
Mandy
On 10/22/18 7:53 AM, Sven Reimers wrote:
Hi Mandy,
will try to get a sample to you.
Which format do you prefer?
Thanks for helping
-Sven
Mandy Chung ma
Hi Mandy,
will try to get a sample to you.
Which format do you prefer?
Thanks for helping
-Sven
Mandy Chung schrieb am So., 21. Okt. 2018, 23:26:
> Hi Sven,
>
> Do you have a sample ThreadInfo to reproduce this issue? That will be
> helpful. JMX monitoring is not impacted as far as I can
Seems like most people are fine with the breakpoint location
for the non stopping cases, so it's OK for me too. Would it make
sense for all breakpoint locations to be displayed from BreakpointEvent().
Thanks for making the extra effort to avoid dependency on
the simple prompt matching. One thing
33 matches
Mail list logo
