Re: RFR: JDK-821430: .attach_pid files may remain in the process cwd

2018-12-01 Thread gary.ad...@oracle.com
Updated webrev:   http://cr.openjdk.java.net/~gadams/8214300/webrev.01/ On 11/30/18 3:10 PM, Chris Plummer wrote: ...and I've been waiting for the webrev update to give it a thumbs up. Chris On 11/30/18 1:11 AM, gary.ad...@oracle.com wrote: I have not refreshed the webrev, yet. Waiting to see

Re: RFR (round 4), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-12-01 Thread Vladimir Kozlov
Much better. Why you need to include shenandoahBarrierSetC2.hpp in /opto/classes.cpp ? Why not include only shenandoahSupport.hpp when new nodes are defined? I think it is fine to not use #ifdef in loopopts.cpp when you check is_ShenandoahBarrier(). And you don't do that in other files. Cod