Hi Ralf,
Overall looks good, but I do have a few suggestions and questions:
I think I prefer passing EI_VM_INIT for triggering_ei, but if you prefer
to keep it as is, I suggest a comment to clarify why it might be out of
range.
The help for "oncmd" says "debug triggered by jcmd?". I think yo
Hi All,
Please review the fix for the bug
https://bugs.openjdk.java.net/browse/JDK-8214892. The webref is at
http://cr.openjdk.java.net/~rrich/webrevs/schmelter/8214892/webrev.01/ .
This change allows debugging to be started delayed, triggered by a jcmd name
VM.start_java_debugging. It works m
Hi, thanks for reviewing. I have made the changes you suggested and also
tidied up the constructors a bit (there was already a 4x Address
constructor), hope that's ok.
Cheers,
David
On Fri, 30 Nov 2018 at 17:06, JC Beyler wrote:
> Hi both,
>
> The webrev looks good to me but I could see gains
