Re: RFR 8215398: -Xlog option usage => Invalid decorator '\temp\app_cds.log'.

Hi Harold, On 19/12/2018 11:22 pm, Harold David Seigel wrote: Hi, Please review this small change to fix JDK-8215398.  The fix works by not treating ':' as a delimiter in a -Xlog... option string if it is following by a '\' and preceded by either a single character or the text 'file='.  The

Re: RFR JDK-8215425: vmTestbase/nsk/jvmti/PopFrame should provide more detailed output

Hi Alexey, The popframe004 test is now failing in tier 4 - [CI] jdk13-jdk.26 Please file a bug and investigate. Thanks, David On 19/12/2018 1:35 pm, JC Beyler wrote: Hi Alex, Looks good to me as well :) Nice job! Jc On Tue, Dec 18, 2018 at 6:10 PM > wrote

Re: [PATCH] JDK-8025886: Replace [[ and == bash extensions in tests

Quickfix on my previous mail: I've found no scripts with the same problem, except this one in the patch. >Yeah, let's fix ! Perfect! I will just need some help with sponsorship to push this. I've signed the OCA, so no problems from my side. Regards, Sergei On Wed, 19 Dec 2018 at 20:22, Martin

Re: RFR (XS) 8215495: Always set isCopy

Looks good to me. Thanks Yumin On Wed, Dec 19, 2018 at 7:42 AM JC Beyler wrote: > Hi all, > > Could I get a second review for this please? :) > > Webrev: http://cr.openjdk.java.net/~jcbeyler/8215495/webrev.01/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8215495 > > Thanks! > Jc > > On Mon,

Re: [PATCH] JDK-8025886: Replace [[ and == bash extensions in tests

Did we really have shell scripts without a shebang line? Yeah, let's fix ! On Wed, Dec 19, 2018 at 11:03 AM Sergei Ustimenko wrote: > HI Martin, > > As you've suggested I've simply added bash's shebang. > It wouldn't add any problem since, as David have mentioned, > no bash - no build. I've also

Re: [PATCH] JDK-8025886: Replace [[ and == bash extensions in tests

HI Martin, As you've suggested I've simply added bash's shebang. It wouldn't add any problem since, as David have mentioned, no bash - no build. I've also quickly checked for similar cases and found one. An updated patch is below. diff --git a/test/jdk/sun/management/jmxremote/bootstrap/Generate

Re: [8u] RFR: 8059038: Create new launcher for SA tools

On Wed, 19 Dec 2018 at 16:59, Severin Gehwolf wrote: > > On Wed, 2018-12-19 at 16:56 +, Andrew Hughes wrote: > > On Wed, 19 Dec 2018 at 12:15, Severin Gehwolf wrote: > > > > > > On Wed, 2018-12-19 at 06:46 +, Andrew Hughes wrote: > > > > On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf > >

Re: [8u] RFR: 8059038: Create new launcher for SA tools

On Wed, 2018-12-19 at 16:56 +, Andrew Hughes wrote: > On Wed, 19 Dec 2018 at 12:15, Severin Gehwolf wrote: > > > > On Wed, 2018-12-19 at 06:46 +, Andrew Hughes wrote: > > > On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf > > > wrote: > > > > > > > > On Thu, 2018-12-13 at 15:49 +, Andr

Re: [8u] RFR: 8059038: Create new launcher for SA tools

On Wed, 19 Dec 2018 at 12:15, Severin Gehwolf wrote: > > On Wed, 2018-12-19 at 06:46 +, Andrew Hughes wrote: > > On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf > > wrote: > > > > > > On Thu, 2018-12-13 at 15:49 +, Andrew Hughes wrote: > > > > Ok, I presume that's not a change you're also g

Re: [12] RFR for JDK-8214122: JDWP is broken on 32 bit Windows: transport library missing onLoad entry

Thank you, Daniel, for your quick review. On 19/12/2018 15:05, Daniel D. Daugherty wrote: On 12/19/18 9:23 AM, Alexey Ivanov wrote: Any volunteers from core-libs and serviceability to review? How about former Serviceability Team members? :-) Alan B. and I both used to be on the Serviceability

Re: [12] RFR for JDK-8214122: JDWP is broken on 32 bit Windows: transport library missing onLoad entry

On 12/19/18 9:23 AM, Alexey Ivanov wrote: Any volunteers from core-libs and serviceability to review? How about former Serviceability Team members? :-) Alan B. and I both used to be on the Serviceability Team... And Alan B. is a current member of Core Libs... > webrev: http://cr.openjdk.java.n

Re: [12] RFR for JDK-8214122: JDWP is broken on 32 bit Windows: transport library missing onLoad entry

Any volunteers from core-libs and serviceability to review? Regards, Alexey On 12/12/2018 16:43, Magnus Ihse Bursie wrote: On 2018-12-12 17:38, Alexey Ivanov wrote: Hi all, I have updated the summary of JDK-8214122 and the subject accordingly. Could you please review the following fix? htt

RFR 8215398: -Xlog option usage => Invalid decorator '\temp\app_cds.log'.

Hi, Please review this small change to fix JDK-8215398.  The fix works by not treating ':' as a delimiter in a -Xlog... option string if it is following by a '\' and preceded by either a single character or the text 'file='.  The fix is for Windows only. Open Webrev: http://cr.openjdk.java.

Re: [8u] RFR: 8059038: Create new launcher for SA tools

On Wed, 2018-12-19 at 06:46 +, Andrew Hughes wrote: > On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf > wrote: > > > > On Thu, 2018-12-13 at 15:49 +, Andrew Hughes wrote: > > > Ok, I presume that's not a change you're also going to make in > > > OpenJDK 12? > > > > Yes. I don't intend to c