[RFR]8215623: Add incremental dump for jmap histo

Hi All, May I ask your help to review this patch for enhance jmap �Chisto. It adds the “incremental” arguments that allow jmap �Chisto to incrementally save the intermediate data into a temp file. The intermediate data is dumped incrementally and write to a rolling file, which limit the

[RFR]8215622: Add dump to file support for jmap histo

Hi All, May I ask your help to review this patch for enhance jmap �Chisto. It add the “file=” arguments that allow jmap �Chisto outputs data to file directly. This patch is also part of the enhancement described in https://bugs.openjdk.java.net/browse/JDK-8214535. Webrev:

Re: RFR 8215398: -Xlog option usage => Invalid decorator '\temp\app_cds.log'.

On 21/12/2018 7:30 am, Harold David Seigel wrote: Hi David, Thanks for looking at this! Please review this updated webrev.  The fix is the same but the webrev contains a new test instead of modifying an existing test: http://cr.openjdk.java.net/~hseigel/bug_8215398.2/webrev/ I think

Re: RFR 8215398: -Xlog option usage => Invalid decorator '\temp\app_cds.log'.

Hi Harold, It looks good to me. Thanks, Serguei On 12/20/18 1:30 PM, Harold David Seigel wrote: Hi David, Thanks for looking at this! Please review this updated webrev.  The fix is the same but the webrev contains a new test instead of modifying an existing test:   

Re: RFR JDK-8215716: PopFrame() was unexpectedly done

Hi Alex, LG++ Thanks, Serguei On 12/20/18 5:09 PM, David Holmes wrote: Looks good. Thanks, David On 21/12/2018 11:04 am, Alex Menkov wrote: Hi all, please review a small fix for https://bugs.openjdk.java.net/browse/JDK-8215716 webrev:

Re: RFR JDK-8215716: PopFrame() was unexpectedly done

Looks good. Thanks, David On 21/12/2018 11:04 am, Alex Menkov wrote: Hi all, please review a small fix for https://bugs.openjdk.java.net/browse/JDK-8215716 webrev: http://cr.openjdk.java.net/~amenkov/popframe004/webrev.01/ The failure is caused by race condition - main test thread calls

RFR JDK-8215716: PopFrame() was unexpectedly done

Hi all, please review a small fix for https://bugs.openjdk.java.net/browse/JDK-8215716 webrev: http://cr.openjdk.java.net/~amenkov/popframe004/webrev.01/ The failure is caused by race condition - main test thread calls PopFrame expecting that test thread is in the activeMethod method. But

Re: RFR 8215398: -Xlog option usage => Invalid decorator '\temp\app_cds.log'.

Hi David, Thanks for looking at this! Please review this updated webrev.  The fix is the same but the webrev contains a new test instead of modifying an existing test: http://cr.openjdk.java.net/~hseigel/bug_8215398.2/webrev/ The logging implementation does not handle single quotes as

Re: JDK-8211343: nsk_jvmti_parseoptions should handle multiple suboptions

Wow, the existing comments for this function take a lot of work to translate. You basically need to understand the code in order to understand the comment. Kind of backwards. Below I've included all the existing code and comments, with my translation of the

Re: JDK-8211343: nsk_jvmti_parseoptions should handle multiple suboptions

I prototyped with strsep, because strtok is not safe and did not want to deal with the strtok_r versus strtok_s (windows) platform variants. ... #include #include int main(int argc, char **argv){ char *str = strdup("waittime=5,verbose foo bar baz=11"); char *name; char *value; while

Re: JDK-8211343: nsk_jvmti_parseoptions should handle multiple suboptions

Hi Gary, I had seen that too and forgot to file it! So thanks! I think the comment you removed is interesting, I'm not sure what it means exactly and I've tried re-reading a few times but the use of "in this question" is weird :-) Anyway, the webrev looks good except perhaps for the use of

Re: RFR: JDK-8215571: jdb does not include jdk.* in the default class filter

Looks good. I've been using it for a while now with no issues. Chris On 12/20/18 4:52 AM, Gary Adams wrote: This should be a trivial update. The default "excludes" filter for jdb should have been updated when the jdk.* packages were first introduced. diff --git

JDK-8211343: nsk_jvmti_parseoptions should handle multiple suboptions

During some earlier jvmti test debugging, I noticed that it was not possible to add a quick argument to the current tests and rerun the test. e.g. expand "waittime=5" to "waittime=5,verbose". I tracked down the options parsing in jvmti_tools.cpp and saw some comments that only a single option

Re: RFR: JDK-8215571: jdb does not include jdk.* in the default class filter

On 20/12/2018 12:52, Gary Adams wrote: This should be a trivial update. The default "excludes" filter for jdb should have been updated when the jdk.* packages were first introduced. This looks okay to me. One thing to mention is that produce a more accurate exclude filter from the packages of

RFR: JDK-8215571: jdb does not include jdk.* in the default class filter

This should be a trivial update. The default "excludes" filter for jdb should have been updated when the jdk.* packages were first introduced. diff --git a/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java b/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java