Re: RFR: 8181313: SA: Remove libthread_db dependency on Linux

2019-01-09 Thread Jini George
Thank you for implementing this change, Yasumasa. It looks good to me. Just a nit. ==> linux/native/libsaproc/libproc_impl.c Could you please remove these lines ? I don't think these are needed anymore. 421 422 // new libthread_db of NPTL seem to require this symbol 423 JNIEXPORT ps_err_e JNI

RE: [RFR]8215622: Add dump to file support for jmap histo

2019-01-09 Thread 臧琳
Dear All, I have updated the refined webrev at http://cr.openjdk.java.net/~xiaofeya/8215622/webrev.02/ Would you like to help review? Thanks! BRs, Lin From: 臧琳 Sent: Wednesday, January 9, 2019 11:00 AM To: 'JC Beyler' Cc: Hohensee, Paul ; serviceability-dev@openjdk.java.net Subject

Re: RFR 8207964: [TESTBUG] Change stressTime to default to 30 for nsk tests

2019-01-09 Thread David Holmes
Hi Harold, cc'd serviceability as a lot of nsk tests are in that area. On 10/01/2019 4:56 am, Harold David Seigel wrote: Hi, Please review this fix to change the default stress time for hotspot vmTestbase tests from 60 seconds to 30 seconds. Which tests actually use this default value? Ope

Re: RFR: JDK-8213001: vmTestbase/nsk/jvmti/ThreadStart/threadstart002/TestDescription.java debug agent times out

2019-01-09 Thread Daniel D. Daugherty
On 1/9/19 10:43 AM, Gary Adams wrote: I could use another reviewer, or an ok to push as a trivial change. Thumbs up! Yes, this qualifies as a trivial change. However, even a trivial change requires a (R)eviewer. JC is currently a committer. Dan On 1/8/19, 11:32 AM, Gary Adams wrote: A num

Re: RFR: JDK-8213001: vmTestbase/nsk/jvmti/ThreadStart/threadstart002/TestDescription.java debug agent times out

2019-01-09 Thread Gary Adams
I could use another reviewer, or an ok to push as a trivial change. On 1/8/19, 11:32 AM, Gary Adams wrote: A number failures of threadstart002 have been reported on windows-x64-debug builds. This configuration has a jtreg timeout factor assigned so the test can run 10x slower and not experie