Yes, I will have a look at it tomorrow.
Chris
On 1/22/19 1:41 PM, [email protected] wrote:
Hi Daniil,
It'd be nice if Chris has a chance to look at this fix.
He has most recent experience in this area.
Thanks,
Serguei
On 1/17/19 6:08 PM, Daniil Titov wrote:
Please review the change
Hi Daniil,
It'd be nice if Chris has a chance to look at this fix.
He has most recent experience in this area.
Thanks,
Serguei
On 1/17/19 6:08 PM, Daniil Titov wrote:
Please review the change that fixes JDB stepping issue for a specific case when the
single step request was initiated earlier
On 1/22/19 12:54 PM, [email protected] wrote:
Hi Jc,
It looks good to me too.
Forgot to say that I hope it was tested well.
Thanks,
Serguei
Thanks,
Serguei
On 1/11/19 5:07 PM, Hohensee, Paul wrote:
Nits:
memAllocator.cpp:
Copyright line should read
* Copyright (c) 2018, 2
Hi Jc,
It looks good to me too.
Thanks,
Serguei
On 1/11/19 5:07 PM, Hohensee, Paul wrote:
Nits:
memAllocator.cpp:
Copyright line should read
* Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights
reserved.
The comment
// Tell tlab to forget the bytes_since if we passed i
Hi Gary,
It looks Okay in general.
But I have a small concern/question about the line:
65 if (!inOutClassFile.renameTo(tmpInOutClassFile)) { What if the
tmpInOutClassFile does exist in the system?
Is it possible there can be some leftover from previous runs?
Thanks,
Serguei
On 1/17/19 3:
Hi Alex,
It looks good to me.
Thanks,
Serguei
On 1/17/19 12:21 PM, Alex Menkov wrote:
Hi Gary,
On 01/17/2019 10:53, Gary Adams wrote:
I like the fact that test.timeout.factor is applied as a multiplier.
It's not clear why an upper limit had to be added.
As you noted there 3 cases where T
