Re: RFR 8205654: serviceability/dcmd/framework/HelpTest.java timed out

On 8/02/2019 10:53 am, Daniil Titov wrote: Hi David, Currently sun.tools.ProcessHelper is implemented for Linux platform only since it uses the proc filesystem that is limited to Linux platform. As a result the test is limited to Linux platform as well. All recorded timeouts that this chan

Re: RFR 8205654: serviceability/dcmd/framework/HelpTest.java timed out

Hi David, Currently sun.tools.ProcessHelper is implemented for Linux platform only since it uses the proc filesystem that is limited to Linux platform. As a result the test is limited to Linux platform as well. All recorded timeouts that this change is fixing were reported for Linux platform

Re: RFR 8205654: serviceability/dcmd/framework/HelpTest.java timed out

Hi Daniil, Thanks for the additional testing. On 8/02/2019 3:52 am, Daniil Titov wrote: Hi Serguei and David, Please review a new version of the fix that adds a new test test/jdk/sun/tools/jcmd/TestProcessHelper.java that starts Java processes using different command line options and verifie

Re: RFR 8205654: serviceability/dcmd/framework/HelpTest.java timed out

Hi Daniil, It looks good to me. Thank you for the update! Thanks, Serguei On 2/7/19 09:52, Daniil Titov wrote: Hi Serguei and David, Please review a new version of the fix that adds a new test test/jdk/sun/tools/jcmd/TestProcessHelper.java that starts Java processes using different command

Re: RFR 8205654: serviceability/dcmd/framework/HelpTest.java timed out

Hi Serguei and David, Please review a new version of the fix that adds a new test test/jdk/sun/tools/jcmd/TestProcessHelper.java that starts Java processes using different command line options and verifies that sun.tools.ProcessHelper.getMainClass(pid) method returns a correct main class. Webr

Re: [aarch64-port-dev ] RFR: 8209413: AArch64: NPE in clhsdb jstack command

On 2/7/19 2:36 PM, Nick Gasson (Arm Technology China) wrote: > > Yeah I tried this method too (see the end of my first email). It > works fine except the PC is off by a few instructions. That can be > fixed quite easily though if required, and it always points into the > right method. We should f

Re: [aarch64-port-dev ] RFR: 8209413: AArch64: NPE in clhsdb jstack command

Hi Andrew, Yeah I tried this method too (see the end of my first email). It works fine except the PC is off by a few instructions. That can be fixed quite easily though if required, and it always points into the right method. I ended up doing the stack scanning thing because as far as I can tel

Re: RFR(S) 8212127: Cleanup TLAB fast refill statistics, perf counters and etc.

On 2019-02-07 15:03, z...@redhat.com wrote: Thanks, Per. Thanks for cleaning this up. GC changes look good. Just one minor thing, please align the assignment here: @@ -147,8 +145,7 @@ void ThreadLocalAllocBuffer::reset_statistics() { _number_of_refills = 0; - _fast_refill_waste = 0; -

Re: RFR(S) 8212127: Cleanup TLAB fast refill statistics, perf counters and etc.

Thanks, Per. > Thanks for cleaning this up. GC changes look good. Just one minor > thing, > please align the assignment here: > > @@ -147,8 +145,7 @@ > > void ThreadLocalAllocBuffer::reset_statistics() { > _number_of_refills = 0; > - _fast_refill_waste = 0; > - _slow_refill_waste = 0; >

Re: [aarch64-port-dev ] RFR: 8209413: AArch64: NPE in clhsdb jstack command

On 2/6/19 6:42 PM, Andrew Haley wrote: > On 2/6/19 10:54 AM, Nick Gasson (Arm Technology China) wrote: >> Hi Andrew >> >>> Here's the test that reveals the problem: it seems that you need an entry >>> frame which calls compiled Java code. >> >> This seems slightly different to the original problem

Re: RFR(S) 8212127: Cleanup TLAB fast refill statistics, perf counters and etc.

Hi, On 2/6/19 3:48 PM, Aleksey Shipilev wrote: On 2/6/19 3:34 PM, z...@redhat.com wrote: *) In src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp, why this whole thing is removed? I would expect "just" the rename of slow_refill_waste() to refill_waste() and removing fast_refill_waste() here