Hello,
Please review the following:
http://cr.openjdk.java.net/~cjplummer/8219143/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8219143
Normally when a breakpoint is set in jdb, it is set globally (all
threads). JDI supports the ability to have the breakpoint be
automatically filtered s
On 19/02/2019 10:07 pm, gary.ad...@oracle.com wrote:
I'm fine with just closing the bug as will not fix.
I personally think it is a non-issue but others (Hi Thomas!) consider it
a real problem.
The issue deals with a situation where the user provided the wrong pid
and the consequences were
Looks good.
Chris
On 2/19/19 1:52 PM, gary.ad...@oracle.com wrote:
Sorry, my bad, used the wrong list of files when I made the webrev.
Added the location, interrupt and setvalue debuggee references.
Webrev: http://cr.openjdk.java.net/~gadams/8219388/webrev.01/
On 2/19/19 3:01 PM, Chris Plum
Sorry, my bad, used the wrong list of files when I made the webrev.
Added the location, interrupt and setvalue debuggee references.
Webrev: http://cr.openjdk.java.net/~gadams/8219388/webrev.01/
On 2/19/19 3:01 PM, Chris Plummer wrote:
Hi Gary,
On 2/19/19 11:38 AM, Gary Adams wrote:
On my fi
Hi Gary,
On 2/19/19 11:38 AM, Gary Adams wrote:
On my first pass I went after cleaning up the issuspend002a messages,
because I'm investigating pulling it off the ProblemList.
I added the setvalue003a misleading log messages in this updated webrev.
3 of the ones I pointed out below that were n
Hi Paul and Lin,
I'm Okay with the fix.
Thanks,
Serguei
On 2/18/19 2:44 PM, Hohensee, Paul wrote:
Looks good. Imo "-histo:" should be valid because it's backward compatible.
Serguei, if you concur I'll push the patch for Lin.
Thanks,
Paul
On 2/17/19, 7:28 PM, "臧琳" wrote:
Dear All,
On my first pass I went after cleaning up the issuspend002a messages,
because I'm investigating pulling it off the ProblemList.
I added the setvalue003a misleading log messages in this updated webrev.
I think the raw "debugee launched" messages are in context of other
messages.
I'd prefer to le
Hi Gary,
Changes look good, but there are other similar incorrect messages you
might also want to address:
./StackFrame/thisObject/thisobject002.java:158: log2("setvalue003a
debuggee launched");
./StackFrame/thisObject/thisobject001.java:159: log2("setvalue003a
debuggee launched");
./StackFr
A log message should have been parameterized
with the debuggeeName.
Issue: https://bugs.openjdk.java.net/browse/JDK-8219388
Webrev: http://cr.openjdk.java.net/~gadams/8219388/webrev.00/
+1. Seemed like a good idea at first, but the potential negative impact
is just too much.
Chris
On 2/19/19 4:07 AM, gary.ad...@oracle.com wrote:
I'm fine with just closing the bug as will not fix.
The issue deals with a situation where the user provided the wrong pid
and the consequences were
I'm fine with just closing the bug as will not fix.
The issue deals with a situation where the user provided the wrong pid
and the consequences were unexpected.
The changes I was prototyping demonstrate that it is possible to restrict
the cases where the attach would be limited to those Java pro
On 2/19/19 6:21 AM, Nick Gasson (Arm Technology China) wrote:
> How about this:
>
> http://cr.openjdk.java.net/~ngasson/8209413/webrev.04/
>
> I changed the two places that currently pass NULL to pass pc() instead
> and changed the FIXME into an assert. I think the result is much cleaner
> with
12 matches
Mail list logo
